Upstream: Test script library from Android

Upstream: Test script library from Android

These are script library from Android and used to run the unit test.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105952

[michaelbai, 2011-10-17 18:28:28]

Hi Mark

Could you help to review README.chromium files and adherence to 3rd party.

@nirnimesh
I am looping you in as an FYI on test methodology we are using.

[Mark Mentovai, 2011-10-17 18:46:39]

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
File third_party/android/README.chromium (right):

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:1: Name: Tools from Android.
Nit: no period necessary.

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:3: Version: unknown
I’m sure there’s some kind of version. This stuff all lives in git, right? You
should have a git hash, then, and a git URL identifying how to pull the files
you’ve got here.

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:4: License: Apache Version 2.0
There needs to be a license file too—call the file LICENSE, and have a “License
File:” entry here referring to it.

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:6: Description: The subdirectories are the
tools from Android which is Gingerbread,
“The subdirectories are the tools from Android Gingerbread, unless stated
otherwise.”

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:8: 
Nit: get rid of the blank line at EOF.

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:8: 
AS AN ALTERNATIVE:

It appears that this directory doesn’t actually contain any third-party code,
and all third-party code is in subdirectories. If that’s the case, this file is
unnecessary and can be removed, provided that all subdirectoires have
README.chromium files.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
File third_party/android/testrunner/README.chromium (right):

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:1: Name: Android Test runner
script.
Same nit as in the other file: no period necessary.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:4: License: Apache Version 2.0
Needs a “License file:” too.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:12: This is no local
modifications, all files were copied from
“There are no local modifications”

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:18: $ repo init -u
git://android.git.kernel.org/platform/manifest.git
How do you check out 3.1.4 specifically, as referenced by the “version” above?

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:24: More information could be
found in
could be -> can be

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:26: 
Same nit as in the other file: no blank line at EOF.

[michaelbai, 2011-10-17 20:48:52]

PTAL

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
File third_party/android/README.chromium (right):

http://codereview.chromium.org/8322008/diff/1/third_party/android/README.chro...
third_party/android/README.chromium:8: 
Yes, I removed this file, thanks

On 2011/10/17 18:46:39, Mark Mentovai wrote:
> AS AN ALTERNATIVE:
> 
> It appears that this directory doesn’t actually contain any third-party code,
> and all third-party code is in subdirectories. If that’s the case, this file
is
> unnecessary and can be removed, provided that all subdirectoires have
> README.chromium files.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
File third_party/android/testrunner/README.chromium (right):

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:1: Name: Android Test runner
script.
On 2011/10/17 18:46:39, Mark Mentovai wrote:
> Same nit as in the other file: no period necessary.

Done.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:4: License: Apache Version 2.0
On 2011/10/17 18:46:39, Mark Mentovai wrote:
> Needs a “License file:” too.

Done.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:12: This is no local
modifications, all files were copied from
On 2011/10/17 18:46:39, Mark Mentovai wrote:
> “There are no local modifications”

Done.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:18: $ repo init -u
git://android.git.kernel.org/platform/manifest.git
On 2011/10/17 18:46:39, Mark Mentovai wrote:
> How do you check out 3.1.4 specifically, as referenced by the
“version” above?

Done.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:24: More information could be
found in
On 2011/10/17 18:46:39, Mark Mentovai wrote:
> could be -> can be

Done.

http://codereview.chromium.org/8322008/diff/1/third_party/android/testrunner/...
third_party/android/testrunner/README.chromium:26: 
On 2011/10/17 18:46:39, Mark Mentovai wrote:
> Same nit as in the other file: no blank line at EOF.

Done.

[Mark Mentovai, 2011-10-17 21:02:11]

http://codereview.chromium.org/8322008/diff/4001/third_party/android/testrunn...
File third_party/android/testrunner/README.chromium (right):

http://codereview.chromium.org/8322008/diff/4001/third_party/android/testrunn...
third_party/android/testrunner/README.chromium:18: $ repo init -u
git://android.git.kernel.org/platform/manifest.git -b gingerbread
Is there a way to do this (either sync or some operation following sync, like
checkout?) to pull the exact version you have pulled here? It’s very useful to
know where in versioned history your changes came from, to help merge things in
the future.

[michaelbai, 2011-10-17 21:41:00]

Thanks, PTAL

http://codereview.chromium.org/8322008/diff/4001/third_party/android/testrunn...
File third_party/android/testrunner/README.chromium (right):

http://codereview.chromium.org/8322008/diff/4001/third_party/android/testrunn...
third_party/android/testrunner/README.chromium:18: $ repo init -u
git://android.git.kernel.org/platform/manifest.git -b gingerbread
On 2011/10/17 21:02:12, Mark Mentovai wrote:
> Is there a way to do this (either sync or some operation following sync, like
> checkout?) to pull the exact version you have pulled here? It’s very useful to
> know where in versioned history your changes came from, to help merge things
in
> the future.

Done.

[Mark Mentovai, 2011-10-17 22:22:50]

Excellent. LGTM.