third_party/android/README.chromium - Issue 8322008: Upstream: Test script library from Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/android/README.chromium

Issue 8322008: Upstream: Test script library from Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: Tools from Android.
	Mark Mentovai 2011/10/17 18:46:39 Nit: no period necessary. Nit: no period necessary.
	2 URL: http://source.android.com

	3 Version: unknown
	Mark Mentovai 2011/10/17 18:46:39 I’m sure there’s some kind of version. This stuff I’m sure there’s some kind of version. This stuff all lives in git, right? You should have a git hash, then, and a git URL identifying how to pull the files you’ve got here.
	4 License: Apache Version 2.0
	Mark Mentovai 2011/10/17 18:46:39 There needs to be a license file too—call the file There needs to be a license file too—call the file LICENSE, and have a “License File:” entry here referring to it.
	5 Security Critical: no

	6 Description: The subdirectories are the tools from Android which is Gingerbread,
	Mark Mentovai 2011/10/17 18:46:39 “The subdirectories are the tools from Android Gin “The subdirectories are the tools from Android Gingerbread, unless stated otherwise.”
	7 unless stated otherwise.

	8
	Mark Mentovai 2011/10/17 18:46:39 Nit: get rid of the blank line at EOF. Nit: get rid of the blank line at EOF. Mark Mentovai 2011/10/17 18:46:39 AS AN ALTERNATIVE: It appears that this directory AS AN ALTERNATIVE: It appears that this directory doesn’t actually contain any third-party code, and all third-party code is in subdirectories. If that’s the case, this file is unnecessary and can be removed, provided that all subdirectoires have README.chromium files. michaelbai 2011/10/17 20:48:52 Yes, I removed this file, thanks On 2011/10/17 18 Yes, I removed this file, thanks On 2011/10/17 18:46:39, Mark Mentovai wrote: Show quoted text > AS AN ALTERNATIVE: > > It appears that this directory doesn’t actually contain any third-party code, > and all third-party code is in subdirectories. If that’s the case, this file is > unnecessary and can be removed, provided that all subdirectoires have > README.chromium files.
OLD	NEW

« no previous file with comments | « no previous file | third_party/android/testrunner/README.chromium » ('j') | third_party/android/testrunner/README.chromium » ('J')