Making some CHECK statements to NOTREACHED.

chrome/browser/sync/syncable/syncable.cc

Index: chrome/browser/sync/syncable/syncable.cc
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc
index d974322accb30a0018fae8ca3fe96656d8471278..741f952fea4289cd17baae1be388eb0cb624c859 100644
--- a/chrome/browser/sync/syncable/syncable.cc
+++ b/chrome/browser/sync/syncable/syncable.cc
@@ -1483,7 +1483,7 @@ bool MutableEntry::PutIsDel(bool is_del) {
   }
 
   if (!is_del)
-    CHECK(PutPredecessor(Id()));  // Restores position to the 0th index.
+    PutPredecessor(Id());  // Restores position to the 0th index.

[akalin, 2011/10/15 00:21:24]

should do something instead of silently dropped.  suggest NOTREACHED()

[lipalani1, 2011/10/15 00:36:31]

Done.

 
   return true;
 }
@@ -1521,7 +1521,7 @@ bool MutableEntry::Put(IdField field, const Id& value) {
         return false;
     } else if (PARENT_ID == field) {
       PutParentIdPropertyOnly(value);  // Makes sibling order inconsistent.
-      CHECK(PutPredecessor(Id()));  // Fixes up the sibling order inconsistency.
+      PutPredecessor(Id());  // Fixes up the sibling order inconsistency.

[akalin, 2011/10/15 00:21:24]

NOTREACHED()

[lipalani1, 2011/10/15 00:36:31]

Done.

     } else {
       kernel_->put(field, value);
     }