Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: chrome/browser/sync/engine/process_commit_response_command.cc

Issue 8298016: Making some CHECK statements to NOTREACHED. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/process_commit_response_command.cc
diff --git a/chrome/browser/sync/engine/process_commit_response_command.cc b/chrome/browser/sync/engine/process_commit_response_command.cc
index 5577c9a14659b7d09423659ceec197001187eecb..3dfe591b81de39fd4634fd07dd99ab05c5b285e6 100644
--- a/chrome/browser/sync/engine/process_commit_response_command.cc
+++ b/chrome/browser/sync/engine/process_commit_response_command.cc
@@ -439,7 +439,8 @@ void ProcessCommitResponseCommand::OverrideClientFieldsAfterCommit(
// value we got applies to the PARENT_ID we submitted.
syncable::Id new_prev = local_entry->ComputePrevIdFromServerPosition(
local_entry->Get(PARENT_ID));
- CHECK(local_entry->PutPredecessor(new_prev));
+ if (!local_entry->PutPredecessor(new_prev))
+ LOG(WARNING) << "PutPredecessor failed after successful commit";
akalin 2011/10/15 00:21:24 NOTREACHED
lipalani1 2011/10/15 00:36:31 Done.
}
}

Powered by Google App Engine
This is Rietveld 408576698