Making some CHECK statements to NOTREACHED.

chrome/browser/sync/syncable/syncable.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/syncable/syncable.h"
 
 #include <algorithm>
 #include <cstring>
 #include <functional>
 #include <iomanip>
@@ skipping 1465 matching lines @@
     // Some indices don't include deleted items and must be updated
     // upon a value change.
     ScopedIndexUpdater<ParentIdAndHandleIndexer> updater(lock, kernel_,
         dir()->kernel_->parent_id_child_index);
 
     kernel_->put(IS_DEL, is_del);
     kernel_->mark_dirty(dir()->kernel_->dirty_metahandles);
   }
 
   if (!is_del)
-    CHECK(PutPredecessor(Id()));  // Restores position to the 0th index.
+    PutPredecessor(Id());  // Restores position to the 0th index.

[akalin, 2011/10/15 00:21:24]

should do something instead of silently dropped.  suggest NOTREACHED()

[lipalani1, 2011/10/15 00:36:31]

Done.

 
   return true;
 }
 
 bool MutableEntry::Put(Int64Field field, const int64& value) {
   DCHECK(kernel_);
   if (kernel_->ref(field) != value) {
     ScopedKernelLock lock(dir());
     if (SERVER_POSITION_IN_PARENT == field) {
       ScopedIndexUpdater<ParentIdAndHandleIndexer> updater(lock, kernel_,
@@ skipping 17 matching lines @@
 }
 
 bool MutableEntry::Put(IdField field, const Id& value) {
   DCHECK(kernel_);
   if (kernel_->ref(field) != value) {
     if (ID == field) {
       if (!dir()->ReindexId(kernel_, value))
         return false;
     } else if (PARENT_ID == field) {
       PutParentIdPropertyOnly(value);  // Makes sibling order inconsistent.
-      CHECK(PutPredecessor(Id()));  // Fixes up the sibling order inconsistency.
+      PutPredecessor(Id());  // Fixes up the sibling order inconsistency.

[akalin, 2011/10/15 00:21:24]

NOTREACHED()

[lipalani1, 2011/10/15 00:36:31]

Done.

     } else {
       kernel_->put(field, value);
     }
     kernel_->mark_dirty(dir()->kernel_->dirty_metahandles);
   }
   return true;
 }
 
 void MutableEntry::PutParentIdPropertyOnly(const Id& parent_id) {
   dir()->ReindexParentId(kernel_, parent_id);
@@ skipping 435 matching lines @@
   CHECK(result);
   for (iterator i = GetParentChildIndexLowerBound(lock, parent_id),
            end = GetParentChildIndexUpperBound(lock, parent_id);
        i != end; ++i) {
     DCHECK_EQ(parent_id, (*i)->ref(PARENT_ID));
     result->push_back((*i)->ref(META_HANDLE));
   }
 }
 
 }  // namespace syncable