Stop copying extension bindings scripts.

Stop copying extension bindings scripts.

After improving v8 API to allow us to pass in an extension source string
length field, use that to refer directly to the in-image source rather
than copying it and holding it in memory, thus saving memory.

It bums me out that I have to call GetRawDataResource() twice, but I don't s
a way around that without abandoning inheritance from v8::Extension and
switching to composition/delegation.

Moved DEPS for v8 to r9534, the newest to include r9365. I don't know whethe
this matches our convention; perhaps we always move DEPS to the latest.

BUG=95147
TEST=relying on existing extensions unit tests, which all still pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110197

[miket_OOO, 2011-10-13 22:21:23]

Please review. I remain ignorant about the rules about moving DEPS.

[mihaip_google.com, 2011-10-13 22:28:16]

On Thu, Oct 13, 2011 at 3:21 PM, <miket@chromium.org> wrote:

> Please review. I remain ignorant about the rules about moving DEPS.
>

Normally v8 rolls are done separately from code changes and to a specific v8
version (e.g. http://crrev.com/105021). Given that the most recent v8 roll
was rolled back (http://crrev.com/105307), I assume there's a problem that
needs to be fixed.

It probably makes sense to coordinate with danno@ or someone else on the v8
team, since it looks like they're trying to roll past r9534 already.

Mihai

[miket_OOO, 2011-10-13 23:17:31]

> It probably makes sense to coordinate with danno@ or someone else on the v8
> team, since it looks like they're trying to roll past r9534 already.

OK, cool. I'll ping him, and ideally this CL will be able to leave DEPS
unchanged from its future state by the time it gets committed.

[Aaron Boodman, 2011-10-14 21:41:09]

lgtm - thanks for staying on top of this

http://codereview.chromium.org/8277020/diff/1/chrome/renderer/extensions/chro...
File chrome/renderer/extensions/chrome_v8_extension.h (right):

http://codereview.chromium.org/8277020/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_v8_extension.h:96: static base::StringPiece
GetStringResourceAsStringPiece(int resource_id);
Nit: No need to encode the returned type in the name unless you're
distinguishing from some other method that returns a different type.

http://codereview.chromium.org/8277020/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_v8_extension.h:97: static int
GetStringResourceLength(int resource_id);
Nit: I don't think it's worth having this extra method when you can just call
size() on the result of the above at the single call site.

[Aaron Boodman, 2011-10-14 21:51:35]

btw, it's no big deal to call GetRawDataResource twice. I think it is pretty
cheap.

[miket_OOO, 2011-10-14 22:16:03]

This CL is now quite small and to-the-point. I'll sit on it until DEPS moves,
then push the shiny button.

[commit-bot: I haz the power, 2011-10-17 16:46:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8277020/6001

[commit-bot: I haz the power, 2011-11-15 21:32:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/8277020/13001

[commit-bot: I haz the power, 2011-11-15 22:50:49]

Change committed as 110197