chrome/renderer/extensions/chrome_v8_extension.h - Issue 8277020: Stop copying extension bindings scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/chrome_v8_extension.h

Issue 8277020: Stop copying extension bindings scripts. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Removed orphaned variable. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/chrome_v8_extension.h

diff --git a/chrome/renderer/extensions/chrome_v8_extension.h b/chrome/renderer/extensions/chrome_v8_extension.h

index a2fe7422376e7fe94bb8c666a8544f0137cc0a72..05d8a26609b5dac0a505364521181ae6c75a368c 100644

--- a/chrome/renderer/extensions/chrome_v8_extension.h

+++ b/chrome/renderer/extensions/chrome_v8_extension.h

@@ -93,7 +93,7 @@ class ChromeV8Extension : public v8::Extension {

ExtensionDispatcher* extension_dispatcher_;

private:

- static const char* GetStringResource(int resource_id);

+ static base::StringPiece GetStringResource(int resource_id);

// Helper to print from bindings javascript.

static v8::Handle<v8::Value> Print(const v8::Arguments& args);

« no previous file with comments | « no previous file | chrome/renderer/extensions/chrome_v8_extension.cc » ('j') | no next file with comments »