More Aura fixes to build with chromeos==1

More Aura fixes to build with chromeos==1

This is not enough to build without stubs for WmIpc, Bubble and ScreenLocker.

TBR=sky@chromium.org
BUG=97131
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105012

[Emmanuel Saint-loubert-Bié, 2011-10-11 23:31:18]

Hi Scott,

Could you please look at the entire CL before I ping each OWNERS?

Thanks,

-- Emmanuel

[sky, 2011-10-12 00:04:33]

Just minor things.

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main_aura.cc (right):

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_aura.cc:9: #include
"chrome/browser/chromeos/cros/cros_library.h"
Should your includes be #ifdefed too?

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_aura.cc:16: :
ChromeBrowserMainParts(parameters) {
this should be indented 2 more spaces.

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_aura.cc:33: NOTIMPLEMENTED();
Do we still need the NOTIMPLEMENTEDs here and in PostMainMessageLoopStart?

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/language_switch_menu.cc (right):

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/language_switch_menu.cc:149: #endif
If you don't have a NOTIMPLEMENTED here, then you probably don't want one in
chrome_browser_main.

[Emmanuel Saint-loubert-Bié, 2011-10-12 00:21:28]

davemoore: please review chomeos/
thestig: printing/ (sorry we keep changing this one)
sky: the rest :-)

Thanks guys!

-- Emmanuel

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main_aura.cc (right):

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_aura.cc:9: #include
"chrome/browser/chromeos/cros/cros_library.h"
On 2011/10/12 00:04:34, sky wrote:
> Should your includes be #ifdefed too?

Done.

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_aura.cc:16: :
ChromeBrowserMainParts(parameters) {
On 2011/10/12 00:04:34, sky wrote:
> this should be indented 2 more spaces.

Done.

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_aura.cc:33: NOTIMPLEMENTED();
On 2011/10/12 00:04:34, sky wrote:
> Do we still need the NOTIMPLEMENTEDs here and in PostMainMessageLoopStart?

Done.

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/language_switch_menu.cc (right):

http://codereview.chromium.org/8233029/diff/1048/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/language_switch_menu.cc:149: #endif
On 2011/10/12 00:04:34, sky wrote:
> If you don't have a NOTIMPLEMENTED here, then you probably don't want one in
> chrome_browser_main.

Done.

[Lei Zhang, 2011-10-12 00:24:40]

LGTM on printing/ bits.

[DaveMoore, 2011-10-12 01:04:08]

chromeos: lgtm

[commit-bot: I haz the power, 2011-10-12 02:09:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/8233029/3023

[commit-bot: I haz the power, 2011-10-12 04:39:44]

Change committed as 105012