Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: chrome/browser/chrome_browser_main_aura.cc

Issue 8233029: More Aura fixes to build with chromeos==1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed x11 issue. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main_aura.h" 5 #include "chrome/browser/chrome_browser_main_aura.h"
6 6
7 #include "base/command_line.h"
7 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/chromeos/cros/cros_library.h"
sky 2011/10/12 00:04:34 Should your includes be #ifdefed too?
Emmanuel Saint-loubert-Bié 2011/10/12 00:21:28 Done.
10 #include "chrome/browser/chromeos/dbus/dbus_thread_manager.h"
11 #include "chrome/common/chrome_switches.h"
12 #include "content/common/main_function_params.h"
8 13
9 ChromeBrowserMainPartsAura::ChromeBrowserMainPartsAura( 14 ChromeBrowserMainPartsAura::ChromeBrowserMainPartsAura(
10 const MainFunctionParams& parameters) 15 const MainFunctionParams& parameters)
11 : ChromeBrowserMainParts(parameters) { 16 : ChromeBrowserMainParts(parameters) {
sky 2011/10/12 00:04:34 this should be indented 2 more spaces.
Emmanuel Saint-loubert-Bié 2011/10/12 00:21:28 Done.
12 NOTIMPLEMENTED(); 17 NOTIMPLEMENTED();
13 } 18 }
14 19
20 ChromeBrowserMainPartsAura::~ChromeBrowserMainPartsAura() {
21 #if defined(OS_CHROMEOS)
22 chromeos::DBusThreadManager::Shutdown();
23 if (!parameters().ui_task && chromeos::CrosLibrary::Get())
24 chromeos::CrosLibrary::Shutdown();
25 #endif
26 }
27
15 void ChromeBrowserMainPartsAura::PreEarlyInitialization() { 28 void ChromeBrowserMainPartsAura::PreEarlyInitialization() {
16 NOTIMPLEMENTED(); 29 NOTIMPLEMENTED();
17 } 30 }
18 31
32 void ChromeBrowserMainPartsAura::PreMainMessageLoopStart() {
33 NOTIMPLEMENTED();
sky 2011/10/12 00:04:34 Do we still need the NOTIMPLEMENTEDs here and in P
Emmanuel Saint-loubert-Bié 2011/10/12 00:21:28 Done.
34 #if defined(OS_CHROMEOS)
35 if (!parameters().ui_task) {
36 bool use_stub = parameters().command_line_.HasSwitch(switches::kStubCros);
37 chromeos::CrosLibrary::Initialize(use_stub);
38 }
39 #endif
40 }
41
19 void ChromeBrowserMainPartsAura::PostMainMessageLoopStart() { 42 void ChromeBrowserMainPartsAura::PostMainMessageLoopStart() {
20 NOTIMPLEMENTED(); 43 NOTIMPLEMENTED();
44 #if defined(OS_CHROMEOS)
45 // Initialize DBusThreadManager for the browser. This must be done after
46 // the main message loop is started, as it uses the message loop.
47 chromeos::DBusThreadManager::Initialize();
48 #endif
21 } 49 }
22 50
23 void ShowMissingLocaleMessageBox() { 51 void ShowMissingLocaleMessageBox() {
24 NOTIMPLEMENTED(); 52 NOTIMPLEMENTED();
25 } 53 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698