Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: chrome/browser/chromeos/login/helper.cc

Issue 8233029: More Aura fixes to build with chromeos==1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Applied sky's comments. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/eula_view.cc ('k') | chrome/browser/chromeos/login/html_page_screen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/helper.cc
diff --git a/chrome/browser/chromeos/login/helper.cc b/chrome/browser/chromeos/login/helper.cc
index 435c7d933cd645e9b1ae6b949e15ad200165b52f..b5e56933cfbebd52e4b84b10ffeb85294f5585fe 100644
--- a/chrome/browser/chromeos/login/helper.cc
+++ b/chrome/browser/chromeos/login/helper.cc
@@ -82,6 +82,7 @@ ThrobberHostView::~ThrobberHostView() {
}
void ThrobberHostView::StartThrobber() {
+#if defined(TOOLKIT_USES_GTK)
StopThrobber();
views::Widget* host_widget = host_view_->GetWidget();
@@ -118,6 +119,10 @@ void ThrobberHostView::StartThrobber() {
// WM can ignore bounds before widget is shown.
throbber_widget_->SetBounds(throbber_bounds);
throbber->Start();
+#else
+ // TODO(saintlou): Do we need a throbber for Aura?
+ NOTIMPLEMENTED();
+#endif
}
void ThrobberHostView::StopThrobber() {
« no previous file with comments | « chrome/browser/chromeos/login/eula_view.cc ('k') | chrome/browser/chromeos/login/html_page_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698