compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java - Issue 8231031: Check for compile-time constants in DartCompiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

Issue 8231031: Check for compile-time constants in DartCompiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Feedback from floitsch Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compiler/javatests/com/google/dart/compiler/backend/js/testFieldAccessExprOpt.dart ('K') | « compiler/javatests/com/google/dart/compiler/resolver/ResolverTests.java ('k') | samples/clock/Balls.dart » ('j') | tests/language/src/ConstInitTest.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

diff --git a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

index 734e27738812240a20a18a1bb45c2d2edd120166..ba4acaafee5cff0d5f214be47be10e309f5f9404 100644

--- a/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

+++ b/compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

@@ -1216,12 +1216,12 @@ public class TypeAnalyzerTest extends TypeTestCase {

Map<String, ClassElement> classes = loadSource(

"class GoodField {",

" static final int i = 1;",

- "}",

- "class BadField {",

- " static final int i = '';",

"}");

analyzeClass(classes.get("GoodField"), 0);

- analyzeClass(classes.get("BadField"), 1);

+ // Note, the TypeAnalyzer doesn't get a chance

+ // to get its hands on bad initializers anymore

+ // due to type checking in CompileTimeConstVisitor.

}

public void testGetAllSupertypes()