tests/language/src/ConstInitTest.dart - Issue 8231031: Check for compile-time constants in DartCompiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/language/src/ConstInitTest.dart

Issue 8231031: Check for compile-time constants in DartCompiler (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Feedback from floitsch Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/language/src/ConstInitTest.dart

diff --git a/tests/language/src/ConstInitTest.dart b/tests/language/src/ConstInitTest.dart

index 9c64e69ee11f4ab6cdc68d559e7f0eb898e5f8e0..3a53c76618d9eb359db3bb9df8be602fe41a9f3b 100644

--- a/tests/language/src/ConstInitTest.dart

+++ b/tests/language/src/ConstInitTest.dart

@@ -42,6 +42,8 @@ class ConstInitTest {

class C2 {

static final Q = const Point(0, 0);

+ // TODO(zundel): Was it intentional to forward reference O, N?

ngeoffray 2011/10/17 10:59:38 Does it matter?

zundel 2011/10/17 14:14:26 As per Florian's request, moved to a separate test

+ // Compiler doesn't recognize the type of O, N as int in that case.

ngeoffray 2011/10/17 10:59:38 Maybe file a bug to fix that in dartc?

zundel 2011/10/17 14:14:26 Codesite issue 120

static final P = 2 * (O - N);

static final O = 1 + 3;

static final N = 1;