Check for compile-time constants in DartCompiler

compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.type;
 
 import com.google.common.base.Joiner;
 import com.google.common.io.CharStreams;
 import com.google.dart.compiler.DartCompilerErrorCode;
 import com.google.dart.compiler.ErrorCode;
@@ skipping 1198 matching lines @@
     analyzeFail("void f([int x = '']) {}", DartCompilerErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
 
     analyze("{ int x = 1; }");
     analyzeFail("{ int x = ''; }", DartCompilerErrorCode.TYPE_NOT_ASSIGNMENT_COMPATIBLE);
   }
 
   public void testInitializedFields() {
     Map<String, ClassElement> classes = loadSource(
         "class GoodField {",
         "  static final int i = 1;",
-        "}",
-        "class BadField {",
-        "  static final int i = '';",
         "}");
     analyzeClass(classes.get("GoodField"), 0);
-    analyzeClass(classes.get("BadField"), 1);
+
+    // Note, the TypeAnalyzer doesn't get a chance
+    // to get its hands on bad initializers anymore
+    // due to type checking in CompileTimeConstVisitor.
   }
 
   public void testGetAllSupertypes()
       throws CyclicDeclarationException, DuplicatedInterfaceException {
     Map<String, ClassElement> classes = loadSource(
         "class A extends B<String> {",
         "}",
         "class B<T> extends C<G<T>> implements I<int>, I1<T> {",
         "}",
         "class C<U> {",
@@ skipping 378 matching lines @@
     public InterfaceType getStringImplementationType() {
       throw new AssertionError();
     }
 
     @Override
     public InterfaceType getIsolateType() {
       throw new AssertionError();
     }
   }
 }