Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8215002: base::Bind: Cleanup in test_shell. (Closed)

Created:
9 years, 2 months ago by James Hawkins
Modified:
9 years, 2 months ago
Reviewers:
michaeln, csilv
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

base::Bind: Cleanup in test_shell. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104796

Patch Set 1 #

Patch Set 2 : Build fix. #

Patch Set 3 : More build fixes. #

Patch Set 4 : Mac build fix. #

Total comments: 6

Patch Set 5 : Review fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -240 lines) Patch
M content/browser/appcache/appcache_dispatcher_host.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 1 2 7 chunks +19 lines, -17 lines 0 comments Download
M webkit/appcache/appcache_backend_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_backend_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_host.h View 3 chunks +13 lines, -14 lines 0 comments Download
M webkit/appcache/appcache_host.cc View 11 chunks +34 lines, -41 lines 0 comments Download
M webkit/appcache/appcache_host_unittest.cc View 1 6 chunks +19 lines, -19 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/mac/webwidget_host.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/notification_presenter.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_appcache_system.cc View 18 chunks +75 lines, -52 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 7 chunks +19 lines, -12 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 9 chunks +43 lines, -31 lines 0 comments Download
M webkit/tools/test_shell/simple_socket_stream_bridge.cc View 8 chunks +12 lines, -13 lines 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_agent.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_devtools_client.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate_gtk.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/webwidget_host_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/webwidget_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
James Hawkins
9 years, 2 months ago (2011-10-10 02:09:38 UTC) #1
michaeln
appcache bits LGTM, thnx!)
9 years, 2 months ago (2011-10-10 19:53:38 UTC) #2
csilv
http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/simple_appcache_system.cc File webkit/tools/test_shell/simple_appcache_system.cc (right): http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/simple_appcache_system.cc#newcode271 webkit/tools/test_shell/simple_appcache_system.cc:271: NewRunnableMethod(this, &SimpleBackendProxy::GetStatus, host_id)); Could you clarify why these next ...
9 years, 2 months ago (2011-10-10 21:01:49 UTC) #3
James Hawkins
http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/simple_appcache_system.cc File webkit/tools/test_shell/simple_appcache_system.cc (right): http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/simple_appcache_system.cc#newcode271 webkit/tools/test_shell/simple_appcache_system.cc:271: NewRunnableMethod(this, &SimpleBackendProxy::GetStatus, host_id)); On 2011/10/10 21:01:49, csilv wrote: > ...
9 years, 2 months ago (2011-10-10 21:55:48 UTC) #4
michaeln
http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/test_shell_webblobregistry_impl.cc File webkit/tools/test_shell/test_shell_webblobregistry_impl.cc (right): http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/test_shell_webblobregistry_impl.cc#newcode7 webkit/tools/test_shell/test_shell_webblobregistry_impl.cc:7: #include "base/bind.h" > test_shell_webblobregistry_impl.cc these are being taken care ...
9 years, 2 months ago (2011-10-10 22:02:21 UTC) #5
James Hawkins
http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/test_shell_webblobregistry_impl.cc File webkit/tools/test_shell/test_shell_webblobregistry_impl.cc (right): http://codereview.chromium.org/8215002/diff/4004/webkit/tools/test_shell/test_shell_webblobregistry_impl.cc#newcode7 webkit/tools/test_shell/test_shell_webblobregistry_impl.cc:7: #include "base/bind.h" On 2011/10/10 22:02:21, michaeln wrote: > > ...
9 years, 2 months ago (2011-10-10 22:06:21 UTC) #6
csilv
9 years, 2 months ago (2011-10-10 22:08:51 UTC) #7 
lgtm

Powered by Google App Engine
This is Rietveld 408576698