webkit/tools/test_shell/layout_test_controller.h - Issue 8215002: base::Bind: Cleanup in test_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/test_shell/layout_test_controller.h

Issue 8215002: base::Bind: Cleanup in test_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/test_shell/layout_test_controller.h

diff --git a/webkit/tools/test_shell/layout_test_controller.h b/webkit/tools/test_shell/layout_test_controller.h

index 3ada2646d9b69f04bd0b271b7c8d8a70ecb23e1f..5e82b0164e7902446ed7e5a61959afdea8b44b31 100644

--- a/webkit/tools/test_shell/layout_test_controller.h

+++ b/webkit/tools/test_shell/layout_test_controller.h

@@ -16,6 +16,7 @@

#include <queue>

+#include "base/memory/weak_ptr.h"

#include "base/timer.h"

#include "base/string16.h"

#include "webkit/glue/cpp_bound_class.h"

@@ -108,7 +109,7 @@ class LayoutTestController : public CppBoundClass {

// Used for test timeouts.

// TODO(ojan): Use base::OneShotTimer.

- ScopedRunnableMethodFactory<LayoutTestController> timeout_factory_;

+ base::WeakPtrFactory<LayoutTestController> weak_factory_;

// Non-owning pointer. The LayoutTestController is owned by the host.

static TestShell* shell_;