Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: webkit/appcache/appcache_host.h

Issue 8215002: base::Bind: Cleanup in test_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review fix. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/appcache/appcache_backend_impl.cc ('k') | webkit/appcache/appcache_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_host.h
diff --git a/webkit/appcache/appcache_host.h b/webkit/appcache/appcache_host.h
index f04b4ef74e61708d63d6f42967ca704a6c112265..c94a1b3fc8d2ae32146ecbe9195ec71b22a89bda 100644
--- a/webkit/appcache/appcache_host.h
+++ b/webkit/appcache/appcache_host.h
@@ -27,9 +27,9 @@ class AppCache;
class AppCacheFrontend;
class AppCacheRequestHandler;
-typedef Callback2<Status, void*>::Type GetStatusCallback;
-typedef Callback2<bool, void*>::Type StartUpdateCallback;
-typedef Callback2<bool, void*>::Type SwapCacheCallback;
+typedef base::Callback<void(Status, void*)> GetStatusCallback;
+typedef base::Callback<void(bool, void*)> StartUpdateCallback;
+typedef base::Callback<void(bool, void*)> SwapCacheCallback;
// Server-side representation of an application cache host.
class APPCACHE_EXPORT AppCacheHost : public AppCacheStorage::Delegate,
@@ -65,11 +65,11 @@ class APPCACHE_EXPORT AppCacheHost : public AppCacheStorage::Delegate,
void SelectCacheForSharedWorker(int64 appcache_id);
void MarkAsForeignEntry(const GURL& document_url,
int64 cache_document_was_loaded_from);
- void GetStatusWithCallback(GetStatusCallback* callback,
+ void GetStatusWithCallback(const GetStatusCallback& callback,
void* callback_param);
- void StartUpdateWithCallback(StartUpdateCallback* callback,
+ void StartUpdateWithCallback(const StartUpdateCallback& callback,
void* callback_param);
- void SwapCacheWithCallback(SwapCacheCallback* callback,
+ void SwapCacheWithCallback(const SwapCacheCallback& callback,
void* callback_param);
// Called prior to the main resource load. When the system contains multiple
@@ -219,14 +219,13 @@ class APPCACHE_EXPORT AppCacheHost : public AppCacheStorage::Delegate,
// Our central service object.
AppCacheService* service_;
- // Since these are synchronous scriptable api calls in the client,
- // there can only be one type of callback pending.
- // Also, we have to wait until we have a cache selection prior
- // to responding to these calls, as cache selection involves
- // async loading of a cache or a group from storage.
- GetStatusCallback* pending_get_status_callback_;
- StartUpdateCallback* pending_start_update_callback_;
- SwapCacheCallback* pending_swap_cache_callback_;
+ // Since these are synchronous scriptable API calls in the client, there can
+ // only be one type of callback pending. Also, we have to wait until we have a
+ // cache selection prior to responding to these calls, as cache selection
+ // involves async loading of a cache or a group from storage.
+ GetStatusCallback pending_get_status_callback_;
+ StartUpdateCallback pending_start_update_callback_;
+ SwapCacheCallback pending_swap_cache_callback_;
void* pending_callback_param_;
// True if a fallback resource was delivered as the main resource.
« no previous file with comments | « webkit/appcache/appcache_backend_impl.cc ('k') | webkit/appcache/appcache_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698