Implement disable_pie for all executables.

Implement disable_pie for all executables.
On setting disable_pie=1 would only build Chrome with the PIE flag disabled. This helped debugging Chrome but browser_tests, ui_tests and other tests + executables were still built with PIE making remote debugging them not possible.

Now when disable_pie=1 is specified, all executables will be built non-PIE.


R=zelidrag@chromium.org,thakis@chromium.org
BUG=None.
TEST=Tested with a complete build. Only and all executables are being linked with '-nopie' with disable_pie=1 specified.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104609

[Nico, 2011-10-07 22:53:25]

http://codereview.chromium.org/8207010/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8207010/diff/1/build/common.gypi#newcode361
build/common.gypi:361: 'disable_pie%': '<(disable_pie)',
It looks like this is not conditionally set. Can't you just say 'disable_pie%':
'0, (like 'channel%' below) and not do this copying?

http://codereview.chromium.org/8207010/diff/1/build/common.gypi#newcode1767
build/common.gypi:1767: ['disable_pie==1', {
since this is linux only, should this be called linux_disable_pie?

[rkc, 2011-10-07 23:23:28]

Review comments incorporated.

http://codereview.chromium.org/8207010/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8207010/diff/1/build/common.gypi#newcode361
build/common.gypi:361: 'disable_pie%': '<(disable_pie)',
On 2011/10/07 22:53:25, Nico wrote:
> It looks like this is not conditionally set. Can't you just say
'disable_pie%':
> '0, (like 'channel%' below) and not do this copying?

Done.

http://codereview.chromium.org/8207010/diff/1/build/common.gypi#newcode1767
build/common.gypi:1767: ['disable_pie==1', {
On 2011/10/07 22:53:25, Nico wrote:
> since this is linux only, should this be called linux_disable_pie?

Done.

[Nico, 2011-10-07 23:49:06]

lgtm