Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: chrome/chrome_exe.gypi

Issue 8207010: Implement disable_pie for all executables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments incorporated. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'chrome', 8 'target_name': 'chrome',
9 'type': 'executable', 9 'type': 'executable',
10 'mac_bundle': 1, 10 'mac_bundle': 1,
11 'variables': { 11 'variables': {
12 'use_system_xdg_utils%': 0, 12 'use_system_xdg_utils%': 0,
13 'disable_pie%': 0,
14 }, 13 },
15 'sources': [ 14 'sources': [
16 'app/breakpad_win.cc', 15 'app/breakpad_win.cc',
17 'app/breakpad_win.h', 16 'app/breakpad_win.h',
18 'app/chrome_exe_main_aura.cc', 17 'app/chrome_exe_main_aura.cc',
19 'app/chrome_exe_main_gtk.cc', 18 'app/chrome_exe_main_gtk.cc',
20 'app/chrome_exe_main_mac.cc', 19 'app/chrome_exe_main_mac.cc',
21 'app/chrome_exe_main_win.cc', 20 'app/chrome_exe_main_win.cc',
22 'app/chrome_exe_resource.h', 21 'app/chrome_exe_resource.h',
23 'app/client_util.cc', 22 'app/client_util.cc',
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 'message': 'Generating manpage' 78 'message': 'Generating manpage'
80 }, 79 },
81 ], 80 ],
82 'conditions': [ 81 'conditions': [
83 ['linux_use_tcmalloc==1', { 82 ['linux_use_tcmalloc==1', {
84 'dependencies': [ 83 'dependencies': [
85 '<(allocator_target)', 84 '<(allocator_target)',
86 ], 85 ],
87 }, 86 },
88 ], 87 ],
89 # TODO(rkc): Remove disable_pie (and instead always use 88 # TODO(rkc): Remove once crosbug.com/15266 is fixed.
90 # -pie) once we have a fix for remote gdb and are able to 89 ['profiling==1', {
91 # correctly get section header offsets for pie
92 # executables. Currently -pie breaks remote debugging.
93 ['profiling==1 or disable_pie==1', {
94 'ldflags': ['-nopie'], 90 'ldflags': ['-nopie'],
95 }, { 91 }, {
96 # Building with -pie needs investigating on ARM. 92 # Building with -pie needs investigating on ARM.
97 # For now, at least use it on Linux Intel. 93 # For now, at least use it on Linux Intel.
98 'conditions': [ 94 'conditions': [
99 ['target_arch=="x64" or target_arch=="ia32"', { 95 ['target_arch=="x64" or target_arch=="ia32"', {
100 'ldflags': ['-pie'], 96 'ldflags': ['-pie'],
101 }], 97 }],
102 ], 98 ],
103 }], 99 }],
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
552 'configurations': { 548 'configurations': {
553 'Common_Base': { 549 'Common_Base': {
554 'msvs_target_platform': 'x64', 550 'msvs_target_platform': 'x64',
555 }, 551 },
556 }, 552 },
557 }, 553 },
558 ], 554 ],
559 }], 555 }],
560 ], 556 ],
561 } 557 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698