Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/chrome_exe.gypi

Issue 8207010: Implement disable_pie for all executables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments incorporated. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi
index 9eb8551d866d42ddedeaf61e3521dba5ff1e2643..46d1553cbae88dcf1c60d8979eab767054f5f942 100644
--- a/chrome/chrome_exe.gypi
+++ b/chrome/chrome_exe.gypi
@@ -10,7 +10,6 @@
'mac_bundle': 1,
'variables': {
'use_system_xdg_utils%': 0,
- 'disable_pie%': 0,
},
'sources': [
'app/breakpad_win.cc',
@@ -86,11 +85,8 @@
],
},
],
- # TODO(rkc): Remove disable_pie (and instead always use
- # -pie) once we have a fix for remote gdb and are able to
- # correctly get section header offsets for pie
- # executables. Currently -pie breaks remote debugging.
- ['profiling==1 or disable_pie==1', {
+ # TODO(rkc): Remove once crosbug.com/15266 is fixed.
+ ['profiling==1', {
'ldflags': ['-nopie'],
}, {
# Building with -pie needs investigating on ARM.
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698