Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 8207004: scoped_ptr and new[] don't mix. (Closed)

Created:
9 years, 2 months ago by Nico
Modified:
9 years, 2 months ago
CC:
chromium-reviews, amit, Paweł Hajdan Jr., sanjeevr
Visibility:
Public.

Description

scoped_ptr and new[] don't mix. BUG=99261 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104592

Patch Set 1 #

Patch Set 2 : ffffffffff #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/browser/external_tab_container_win.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/urlmon_moniker_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/backend/print_backend_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
9 years, 2 months ago (2011-10-07 20:55:48 UTC) #1
willchan no longer on Chromium
LGTM
9 years, 2 months ago (2011-10-07 20:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8207004/1
9 years, 2 months ago (2011-10-07 20:59:08 UTC) #3
Lei Zhang
LGTM++
9 years, 2 months ago (2011-10-07 21:01:22 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8207004/4003
9 years, 2 months ago (2011-10-07 21:30:45 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-10-07 22:55:49 UTC) #6
Change committed as 104592

Powered by Google App Engine
This is Rietveld 408576698