chrome/service/cloud_print/print_system_win.cc - Issue 8207004: scoped_ptr and new[] don't mix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/print_system_win.cc

Issue 8207004: scoped_ptr and new[] don't mix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ffffffffff Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/cloud_print/print_system_win.cc

diff --git a/chrome/service/cloud_print/print_system_win.cc b/chrome/service/cloud_print/print_system_win.cc

index a78aff01616200074a4d2d85617b1ad210ff617f..5a99d90686eaa114642e59dd86a1d704029abd3d 100644

--- a/chrome/service/cloud_print/print_system_win.cc

+++ b/chrome/service/cloud_print/print_system_win.cc

@@ -808,7 +808,7 @@ bool PrintSystemWin::GetJobDetails(const std::string& printer_name,

if (ERROR_INVALID_PARAMETER != last_error) {

// ERROR_INVALID_PARAMETER normally means that the job id is not valid.

DCHECK(last_error == ERROR_INSUFFICIENT_BUFFER);

- scoped_ptr<BYTE> job_info_buffer(new BYTE[bytes_needed]);

+ scoped_array<BYTE> job_info_buffer(new BYTE[bytes_needed]);

if (GetJob(printer_handle, job_id, 1, job_info_buffer.get(), bytes_needed,

&bytes_needed)) {

JOB_INFO_1 *job_info =