Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome_frame/test/urlmon_moniker_unittest.cc

Issue 8207004: scoped_ptr and new[] don't mix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ffffffffff Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/cloud_print/print_system_win.cc ('k') | printing/backend/print_backend_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/urlmon_moniker_unittest.cc
diff --git a/chrome_frame/test/urlmon_moniker_unittest.cc b/chrome_frame/test/urlmon_moniker_unittest.cc
index f7e0f048fd2f55d0a4db735af7baf4abd3eb8468..1e1126baa7d9a7548f144e4b73b124b94c228331 100644
--- a/chrome_frame/test/urlmon_moniker_unittest.cc
+++ b/chrome_frame/test/urlmon_moniker_unittest.cc
@@ -173,7 +173,7 @@ TEST_F(MonikerPatchTest, SniffDataPlayback1) {
const DWORD data_size = small_html_meta_tag.size();
DWORD read_size1 = data_size * 2;
- scoped_ptr<char> read_buffer1(new char[read_size1]);
+ scoped_array<char> read_buffer1(new char[read_size1]);
ZeroMemory(read_buffer1.get(), read_size1);
char read_buffer2[10] = {0};
@@ -217,8 +217,8 @@ TEST_F(MonikerPatchTest, SniffDataPlayback2) {
DWORD read_size1 = data_size / 2; // First read is half the data.
DWORD read_size2 = data_size; // Second read, try to read past data.
- scoped_ptr<char> read_buffer1(new char[read_size1]);
- scoped_ptr<char> read_buffer2(new char[read_size2]);
+ scoped_array<char> read_buffer1(new char[read_size1]);
+ scoped_array<char> read_buffer2(new char[read_size2]);
ZeroMemory(read_buffer1.get(), read_size1);
ZeroMemory(read_buffer2.get(), read_size2);
« no previous file with comments | « chrome/service/cloud_print/print_system_win.cc ('k') | printing/backend/print_backend_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698