Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 8200015: Add support for an optional "requirements" section in extension/app manifests. (Closed)

Created:
9 years, 2 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add support for an optional "requirements" section in extension/app manifests. The expected format is: "requirements": { "requirement1": { // requirement details }, "requiement2": { // requirement details }, ... } Only validation and whitelisting for hosted apps is done, for now only the web store will use requirements data. BUG=99241 R=yoz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104582

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M chrome/common/extensions/extension.cc View 2 chunks +23 lines, -1 line 3 comments Download
M chrome/common/extensions/extension_constants.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension_manifests_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
A chrome/test/data/extensions/manifest_tests/init_invalid_requirements_1.json View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/init_invalid_requirements_2.json View 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/manifest_tests/init_valid_app_requirements.json View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mihai Parparita -not on Chrome
9 years, 2 months ago (2011-10-07 20:57:10 UTC) #1
Yoyo Zhou
LGTM http://codereview.chromium.org/8200015/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/8200015/diff/1/chrome/common/extensions/extension.cc#newcode2391 chrome/common/extensions/extension.cc:2391: if (!requirements_value->GetDictionaryWithoutPathExpansion( Any particular reason to use the ...
9 years, 2 months ago (2011-10-07 21:05:32 UTC) #2
Mihai Parparita -not on Chrome
http://codereview.chromium.org/8200015/diff/1/chrome/common/extensions/extension.cc File chrome/common/extensions/extension.cc (right): http://codereview.chromium.org/8200015/diff/1/chrome/common/extensions/extension.cc#newcode2391 chrome/common/extensions/extension.cc:2391: if (!requirements_value->GetDictionaryWithoutPathExpansion( On 2011/10/07 21:05:33, Yoyo Zhou wrote: > ...
9 years, 2 months ago (2011-10-07 21:15:32 UTC) #3
Yoyo Zhou
9 years, 2 months ago (2011-10-07 21:19:11 UTC) #4
http://codereview.chromium.org/8200015/diff/1/chrome/common/extensions/extens...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/8200015/diff/1/chrome/common/extensions/extens...
chrome/common/extensions/extension.cc:2391: if
(!requirements_value->GetDictionaryWithoutPathExpansion(
On 2011/10/07 21:15:32, Mihai Parparita wrote:
> On 2011/10/07 21:05:33, Yoyo Zhou wrote:
> > Any particular reason to use the WithoutPathExpansion version?
> 
> The iterator docs say that should be used
> (http://www.google.com/codesearch#OAMlx_jo-ck/src/base/values.h&l=320), in
case
> there are keys with periods in the name.

Ok, I didn't realize we would have such keys (from our limited example set).

Powered by Google App Engine
This is Rietveld 408576698