Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5014)

Unified Diff: chrome/common/extensions/extension_manifests_unittest.cc

Issue 8200015: Add support for an optional "requirements" section in extension/app manifests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_manifests_unittest.cc
diff --git a/chrome/common/extensions/extension_manifests_unittest.cc b/chrome/common/extensions/extension_manifests_unittest.cc
index dd1f4f8a6cb02b576b7cb1bb7a5b5cdbe3825dd6..99393722af9b2ec771a4efab6e27bf3619f7f5a1 100644
--- a/chrome/common/extensions/extension_manifests_unittest.cc
+++ b/chrome/common/extensions/extension_manifests_unittest.cc
@@ -207,7 +207,9 @@ TEST_F(ExtensionManifestTest, InitFromValueInvalid) {
{"init_invalid_locale_empty.json", errors::kInvalidDefaultLocale},
{"init_invalid_min_chrome_invalid.json",
errors::kInvalidMinimumChromeVersion},
- {"init_invalid_chrome_version_too_low.json", errors::kChromeVersionTooLow}
+ {"init_invalid_chrome_version_too_low.json", errors::kChromeVersionTooLow},
+ {"init_invalid_requirements_1.json", errors::kInvalidRequirements},
+ {"init_invalid_requirements_2.json", errors::kInvalidRequirement}
};
RunTestcases(testcases, arraysize(testcases));
@@ -248,6 +250,9 @@ TEST_F(ExtensionManifestTest, InitFromValueValid) {
// Test a hosted app with a minimum_chrome_version.
extension = LoadAndExpectSuccess("init_valid_app_minimum_chrome.json");
+ // Test a hosted app with a requirements section.
+ extension = LoadAndExpectSuccess("init_valid_app_requirements.json");
+
// Verify empty permission settings are considered valid.
LoadAndExpectSuccess("init_valid_permissions_empty.json");

Powered by Google App Engine
This is Rietveld 408576698