chrome/common/extensions/extension_constants.cc - Issue 8200015: Add support for an optional "requirements" section in extension/app manifests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_constants.cc

Issue 8200015: Add support for an optional "requirements" section in extension/app manifests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/extension.cc ('K') | « chrome/common/extensions/extension_constants.h ('k') | chrome/common/extensions/extension_manifests_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_constants.cc

diff --git a/chrome/common/extensions/extension_constants.cc b/chrome/common/extensions/extension_constants.cc

index 621fb63f50848f7c5344a1755cb0f3970649c461..53c5496b5906e31f752a10483a1e115ccf4f0fba 100644

--- a/chrome/common/extensions/extension_constants.cc

+++ b/chrome/common/extensions/extension_constants.cc

@@ -80,6 +80,7 @@ const char* kPlugins = "plugins";

const char* kPluginsPath = "path";

const char* kPluginsPublic = "public";

const char* kPublicKey = "key";

+const char* kRequirements = "requirements";

const char* kRunAt = "run_at";

const char* kShiftKey = "shiftKey";

const char* kShortcutKey = "shortcutKey";

@@ -338,6 +339,10 @@ const char* kInvalidPluginsPath =

"Invalid value for 'plugins[*].path'.";

const char* kInvalidPluginsPublic =

"Invalid value for 'plugins[*].public'.";

+const char* kInvalidRequirement =

+ "Invalid value for requirement \"*\"";

+const char* kInvalidRequirements =

+ "Invalid value for 'requirements'";

const char* kInvalidRunAt =

"Invalid value for 'content_scripts[*].run_at'.";

const char* kInvalidSidebar =