chrome/browser/sync/signin_manager.cc - Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/signin_manager.cc

Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix chromeos Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_impl.cc ('K') | « chrome/browser/search_engines/template_url_service.cc ('k') | chrome/browser/sync/sync_prefs.cc » ('j') | chrome/common/json_pref_store.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/signin_manager.cc

diff --git a/chrome/browser/sync/signin_manager.cc b/chrome/browser/sync/signin_manager.cc

index 6c65c3fddfee6082d335b6c6602721dd71ce4817..ac4ece4e69d17af66021a397161abc6667a0fefc 100644

--- a/chrome/browser/sync/signin_manager.cc

+++ b/chrome/browser/sync/signin_manager.cc

@@ -176,7 +176,6 @@ void SigninManager::SignOut() {

had_two_factor_error_ = false;

profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesUsername);

profile_->GetPrefs()->ClearPref(prefs::kSyncUsingOAuth);

- profile_->GetPrefs()->ScheduleSavePersistentPrefs();

profile_->GetTokenService()->ResetCredentialsInMemory();

profile_->GetTokenService()->EraseTokensFromDB();

}

@@ -197,7 +196,6 @@ void SigninManager::OnGetUserInfoSuccess(const std::string& key,

username_ = value;

profile_->GetPrefs()->SetString(prefs::kGoogleServicesUsername, username_);

profile_->GetPrefs()->SetBoolean(prefs::kSyncUsingOAuth, false);

- profile_->GetPrefs()->ScheduleSavePersistentPrefs();

GoogleServiceSigninSuccessDetails details(username_, password_);

NotificationService::current()->Notify(

@@ -300,7 +298,6 @@ void SigninManager::OnUserInfoSuccess(const std::string& email) {

profile_->GetPrefs()->SetString(

prefs::kGoogleServicesUsername, oauth_username_);

profile_->GetPrefs()->SetBoolean(prefs::kSyncUsingOAuth, true);

- profile_->GetPrefs()->ScheduleSavePersistentPrefs();

DCHECK(password_.empty());

GoogleServiceSigninSuccessDetails details(oauth_username_, "");