Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs.

chrome/browser/profiles/profile_impl.cc

Index: chrome/browser/profiles/profile_impl.cc
diff --git a/chrome/browser/profiles/profile_impl.cc b/chrome/browser/profiles/profile_impl.cc
index 44c7774eaa464774db66c369108e4661d2fe09cf..e67a06efc5627ece16ce5c0b23fcbc6d9d29f572 100644
--- a/chrome/browser/profiles/profile_impl.cc
+++ b/chrome/browser/profiles/profile_impl.cc
@@ -924,8 +924,6 @@ void ProfileImpl::OnPrefsLoaded(bool success) {
       prefs_->GetBoolean(prefs::kSessionExitedCleanly);
   // Mark the session as open.
   prefs_->SetBoolean(prefs::kSessionExitedCleanly, false);
-  // Make sure we save to disk that the session has opened.
-  prefs_->ScheduleSavePersistentPrefs();

[Mattias Nissler (ping if slow), 2011/10/12 09:23:39]

At this point I think we actually want a CommitPendingWrite() in order to make
sure that crashes happening immediately after are detected as unclean exit.

[Bernhard Bauer, 2011/10/12 11:00:11]

Hm, could this adversely affect startup performance, or am I being overly
paranoid here?

[Mattias Nissler (ping if slow), 2011/10/12 11:02:27]

Ah, the old fast vs. correct tradeoff :) I'm OK either way.

 
   bool extensions_disabled =
       prefs_->GetBoolean(prefs::kDisableExtensions) ||
@@ -1468,7 +1466,7 @@ void ProfileImpl::MarkAsCleanShutdown() {
 
     // NOTE: If you change what thread this writes on, be sure and update
     // ChromeFrame::EndSession().
-    prefs_->SavePersistentPrefs();
+    prefs_->CommitPendingWrite();
   }
 }
 
@@ -1719,9 +1717,6 @@ void ProfileImpl::ChangeAppLocale(
 
   if (chromeos::UserManager::Get()->current_user_is_owner())
     local_state->SetString(prefs::kOwnerLocale, new_locale);
-
-  GetPrefs()->ScheduleSavePersistentPrefs();
-  local_state->ScheduleSavePersistentPrefs();
 }
 
 void ProfileImpl::OnLogin() {