Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2142)

Unified Diff: chrome/browser/sync/sync_prefs.cc

Issue 8198007: Remove PrefService::ScheduleSavePersistentPrefs and SavePersistentPrefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix chromeos Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/sync_prefs.cc
diff --git a/chrome/browser/sync/sync_prefs.cc b/chrome/browser/sync/sync_prefs.cc
index 45c75d8abc2a78eb069714f6c170b5faaab577d9..764d3a3a33836dde8530c54390f693790281ccb9 100644
--- a/chrome/browser/sync/sync_prefs.cc
+++ b/chrome/browser/sync/sync_prefs.cc
@@ -49,7 +49,6 @@ void SyncPrefs::ClearPreferences() {
// TODO(nick): The current behavior does not clear
// e.g. prefs::kSyncBookmarks. Is that really what we want?
- pref_service_->ScheduleSavePersistentPrefs();
}
bool SyncPrefs::HasSyncSetupCompleted() const {
@@ -64,7 +63,6 @@ void SyncPrefs::SetSyncSetupCompleted() {
CHECK(pref_service_);
pref_service_->SetBoolean(prefs::kSyncHasSetupCompleted, true);
SetStartSuppressed(false);
- pref_service_->ScheduleSavePersistentPrefs();
}
bool SyncPrefs::IsStartSuppressed() const {
@@ -78,7 +76,6 @@ void SyncPrefs::SetStartSuppressed(bool is_suppressed) {
DCHECK(non_thread_safe_.CalledOnValidThread());
CHECK(pref_service_);
pref_service_->SetBoolean(prefs::kSyncSuppressStart, is_suppressed);
- pref_service_->ScheduleSavePersistentPrefs();
}
base::Time SyncPrefs::GetLastSyncedTime() const {
@@ -93,7 +90,6 @@ void SyncPrefs::SetLastSyncedTime(base::Time time) {
DCHECK(non_thread_safe_.CalledOnValidThread());
CHECK(pref_service_);
pref_service_->SetInt64(prefs::kSyncLastSyncedTime, time.ToInternalValue());
- pref_service_->ScheduleSavePersistentPrefs();
}
bool SyncPrefs::HasKeepEverythingSynced() const {
@@ -108,7 +104,6 @@ void SyncPrefs::SetKeepEverythingSynced(bool keep_everything_synced) {
CHECK(pref_service_);
pref_service_->SetBoolean(prefs::kSyncKeepEverythingSynced,
keep_everything_synced);
- pref_service_->ScheduleSavePersistentPrefs();
}
syncable::ModelTypeSet SyncPrefs::GetPreferredDataTypes(
@@ -190,7 +185,6 @@ void SyncPrefs::SetEncryptionBootstrapToken(const std::string& token) {
DCHECK(non_thread_safe_.CalledOnValidThread());
CHECK(pref_service_);
pref_service_->SetString(prefs::kSyncEncryptionBootstrapToken, token);
- pref_service_->ScheduleSavePersistentPrefs();
}
void SyncPrefs::AcknowledgeSyncedTypes(
@@ -214,7 +208,6 @@ void SyncPrefs::AcknowledgeSyncedTypes(
scoped_ptr<ListValue> value(
syncable::ModelTypeSetToValue(acknowledged_types));
pref_service_->Set(prefs::kSyncAcknowledgedSyncTypes, *value);
- pref_service_->ScheduleSavePersistentPrefs();
}
void SyncPrefs::Observe(int type,
@@ -242,7 +235,6 @@ void SyncPrefs::SetManagedForTest(bool is_managed) {
DCHECK(non_thread_safe_.CalledOnValidThread());
CHECK(pref_service_);
pref_service_->SetBoolean(prefs::kSyncManaged, is_managed);
- pref_service_->ScheduleSavePersistentPrefs();
}
syncable::ModelTypeSet SyncPrefs::GetAcknowledgeSyncedTypesForTest() const {
@@ -401,7 +393,6 @@ void SyncPrefs::SetDataTypePreferred(
return;
}
pref_service_->SetBoolean(pref_name, is_preferred);
- pref_service_->ScheduleSavePersistentPrefs();
}
} // namespace browser_sync

Powered by Google App Engine
This is Rietveld 408576698