Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 8139038: Provide correct extra info for ChromeOS (Closed)

Created:
9 years, 2 months ago by stevenjb
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Provide extra info form ARM BUG=99190 TEST=ARM bots build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106343

Patch Set 1 #

Patch Set 2 : Provide extra info for ARM #

Patch Set 3 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M chrome/browser/component_updater/component_updater_configurator.cc View 1 2 1 chunk +10 lines, -7 lines 2 comments Download

Messages

Total messages: 9 (0 generated)
stevenjb
Fixing the ordering so that ChromeOS gets the right extra info.
9 years, 2 months ago (2011-10-15 01:57:31 UTC) #1
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/8139038/diff/5001/chrome/browser/component_updater/component_updater_configurator.cc File chrome/browser/component_updater/component_updater_configurator.cc (left): http://codereview.chromium.org/8139038/diff/5001/chrome/browser/component_updater/component_updater_configurator.cc#oldcode69 chrome/browser/component_updater/component_updater_configurator.cc:69: #else but I thought that chromeos also defines OS_LINUX ...
9 years, 2 months ago (2011-10-17 01:11:44 UTC) #2
stevenjb
http://codereview.chromium.org/8139038/diff/5001/chrome/browser/component_updater/component_updater_configurator.cc File chrome/browser/component_updater/component_updater_configurator.cc (left): http://codereview.chromium.org/8139038/diff/5001/chrome/browser/component_updater/component_updater_configurator.cc#oldcode69 chrome/browser/component_updater/component_updater_configurator.cc:69: #else On 2011/10/17 01:11:44, cpu wrote: > but I ...
9 years, 2 months ago (2011-10-17 17:26:11 UTC) #3
stevenjb
ping?
9 years, 2 months ago (2011-10-19 00:05:37 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
9 years, 2 months ago (2011-10-19 17:34:52 UTC) #5
cpu_(ooo_6.6-7.5)
also note http://codereview.chromium.org/8344001/
9 years, 2 months ago (2011-10-19 17:35:41 UTC) #6
stevenjb
Thanks, and thanks for the heads-up.
9 years, 2 months ago (2011-10-19 17:51:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/8139038/5001
9 years, 2 months ago (2011-10-19 17:51:59 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-19 19:20:29 UTC) #9
Change committed as 106343

Powered by Google App Engine
This is Rietveld 408576698