OpenBSD patches for chrome/content, split from CR #8275005

OpenBSD patches for chrome/content, split from CR #8275005

about_flags.cc: define kOsLinux on OpenBSD too for flags

chrome_content_browser_client.cc: Replace OS_LINUX
with TOOLKIT_USES_GTK so that Gtk+ platforms can share the
code.

component_updater_configurator.cc: OpenBSD defs. for the
updater.

chrome_browser.gypi: The dl library is linux only here.

pepper_message_filter.cc: This asserts fails on OpenBSD
so let's disable it for now so that the porting effort
can move ahead and this issue can be investigated later.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106765

[Robert Sesek, 2011-10-18 16:52:18]

Why did you send me this review? Please find more appropriate reviewers.

[Elliot Glaysher, 2011-10-18 17:25:44]

http://codereview.chromium.org/8344001/diff/1/chrome/browser/component_update...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

http://codereview.chromium.org/8344001/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/component_updater_configurator.cc:73: #elif
defined(OS_OPENBSD)
+cpu

Is this OK? Will we barf if this is passed to the web store?

[Robert Nagy, 2011-10-18 17:29:28]

http://codereview.chromium.org/8344001/diff/1/chrome/browser/component_update...
File chrome/browser/component_updater/component_updater_configurator.cc (right):

http://codereview.chromium.org/8344001/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/component_updater_configurator.cc:73: #elif
defined(OS_OPENBSD)
On 2011/10/18 17:25:44, Elliot Glaysher wrote:
> +cpu
> 
> Is this OK? Will we barf if this is passed to the web store?
Well I do not know, but it is a different platform, so I can't just define linux
here.

[cpu_(ooo_6.6-7.5), 2011-10-18 21:02:03]

lgtm on the component updater part.

[Elliot Glaysher, 2011-10-18 21:02:51]

On 2011/10/18 21:02:03, cpu wrote:
> lgtm on the component updater part.

then lgtm in general. that was my only concern.

[stevenjb, 2011-10-19 17:50:47]

http://codereview.chromium.org/8344001/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8344001/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:84: #include
"chrome/browser/chromeos/chrome_browser_main_chromeos.h"
CHROMEOS is already define at the top of this list.

http://codereview.chromium.org/8344001/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:199: #elif defined(OS_CHROMEOS)
CHROMEOS is already define at the top of this list.

[Robert Nagy, 2011-10-19 20:17:48]

http://codereview.chromium.org/8344001/diff/1/chrome/browser/chrome_content_b...
File chrome/browser/chrome_content_browser_client.cc (right):

http://codereview.chromium.org/8344001/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:84: #include
"chrome/browser/chromeos/chrome_browser_main_chromeos.h"
On 2011/10/19 17:50:48, Steven Bennetts wrote:
> CHROMEOS is already define at the top of this list.

Done.

http://codereview.chromium.org/8344001/diff/1/chrome/browser/chrome_content_b...
chrome/browser/chrome_content_browser_client.cc:199: #elif defined(OS_CHROMEOS)
On 2011/10/19 17:50:48, Steven Bennetts wrote:
> CHROMEOS is already define at the top of this list.

Done.

[stevenjb, 2011-10-19 20:41:09]

LGTM
You'll need to rebase component_updater_configurator.cc (OS_CHROMEOS section got
moved up in http://codereview.chromium.org/8139038/).

[Robert Nagy, 2011-10-19 20:51:17]

On 2011/10/19 20:41:09, Steven Bennetts wrote:
> LGTM
> You'll need to rebase component_updater_configurator.cc (OS_CHROMEOS section
got
> moved up in http://codereview.chromium.org/8139038/).

rebased.

[Robert Nagy, 2011-10-20 22:01:21]

On 2011/10/19 20:41:09, Steven Bennetts wrote:
> LGTM
> You'll need to rebase component_updater_configurator.cc (OS_CHROMEOS section
got
> moved up in http://codereview.chromium.org/8139038/).

Can you please hit commit for me?

[commit-bot: I haz the power, 2011-10-20 22:02:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8344001/7001

[commit-bot: I haz the power, 2011-10-20 22:02:37]

Presubmit check for 8344001-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
content/browser/renderer_host/pepper_message_filter.cc

Presubmit checks took 1.2s to calculate.

[Robert Nagy, 2011-10-21 08:13:48]

On 2011/10/20 22:02:37, I haz the power (commit-bot) wrote:
> Presubmit check for 8344001-7001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change has an associated bug, add BUG=[bug number].
> 
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for:
> content/browser/renderer_host/pepper_message_filter.cc
> 
> Presubmit checks took 1.2s to calculate.

John can you please review this?

[jam, 2011-10-21 16:10:54]

lgtm with nit

http://codereview.chromium.org/8344001/diff/7001/content/browser/renderer_hos...
File content/browser/renderer_host/pepper_message_filter.cc (right):

http://codereview.chromium.org/8344001/diff/7001/content/browser/renderer_hos...
content/browser/renderer_host/pepper_message_filter.cc:133: #if
!defined(OS_OPENBSD)
nit: add a comment about why this is ifdef'd for openbsd

[Robert Nagy, 2011-10-21 18:10:19]

http://codereview.chromium.org/8344001/diff/7001/content/browser/renderer_hos...
File content/browser/renderer_host/pepper_message_filter.cc (right):

http://codereview.chromium.org/8344001/diff/7001/content/browser/renderer_hos...
content/browser/renderer_host/pepper_message_filter.cc:133: #if
!defined(OS_OPENBSD)
On 2011/10/21 16:10:55, John Abd-El-Malek wrote:
> nit: add a comment about why this is ifdef'd for openbsd

Done.

[Robert Nagy, 2011-10-21 18:10:39]

On 2011/10/21 18:10:19, Robert Nagy wrote:
>
http://codereview.chromium.org/8344001/diff/7001/content/browser/renderer_hos...
> File content/browser/renderer_host/pepper_message_filter.cc (right):
> 
>
http://codereview.chromium.org/8344001/diff/7001/content/browser/renderer_hos...
> content/browser/renderer_host/pepper_message_filter.cc:133: #if
> !defined(OS_OPENBSD)
> On 2011/10/21 16:10:55, John Abd-El-Malek wrote:
> > nit: add a comment about why this is ifdef'd for openbsd
> 
> Done.
Oh and please someone hit commit for me :)

[commit-bot: I haz the power, 2011-10-21 18:15:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8344001/14001

[commit-bot: I haz the power, 2011-10-21 19:50:23]

Change committed as 106765