Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: chrome/browser/component_updater/component_updater_configurator.cc

Issue 8139038: Provide correct extra info for ChromeOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/component_updater_configurator.cc
diff --git a/chrome/browser/component_updater/component_updater_configurator.cc b/chrome/browser/component_updater/component_updater_configurator.cc
index c53f62aa416b5bb5f96072a361b94e35eb01b042..aff33e7350b57ed4a3b22c6fef416a517674337f 100644
--- a/chrome/browser/component_updater/component_updater_configurator.cc
+++ b/chrome/browser/component_updater/component_updater_configurator.cc
@@ -55,21 +55,24 @@ const char kExtraInfo[] =
#else
#error "unknown windows architecture"
#endif
+#elif defined(OS_CHROMEOS)
+ #if defined(__i386__)
+ "os=cros&arch=x86&prod=chrome&prodversion=";
+ #elif defined(__arm__)
+ "os=cros&arch=arm&prod=chrome&prodversion=";
+ #else
+ "os=cros&arch=unknown&prod=chrome&prodversion=";
+ #endif
#elif defined(OS_LINUX)
#if defined(__amd64__)
"os=linux&arch=x64&prod=chrome&prodversion=";
#elif defined(__i386__)
"os=linux&arch=x86&prod=chrome&prodversion=";
+ #elif defined(__arm__)
+ "os=linux&arch=arm&prod=chrome&prodversion=";
#else
"os=linux&arch=unknown&prod=chrome&prodversion=";
#endif
-#elif defined(OS_CHROMEOS)
- #if defined(__i386__)
- "os=cros&arch=x86&prod=chrome&prodversion=";
- #else
cpu_(ooo_6.6-7.5) 2011/10/17 01:11:44 but I thought that chromeos also defines OS_LINUX
stevenjb 2011/10/17 17:26:11 That's correct, OS_CHROMEOS also defins OS_LINUX.
- // TODO(cpu): Fix this for ARM.
- "os=cros&arch=unknown&prod=chrome&prodversion=";
- #endif
#else
#error "unknown os or architecture"
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698