Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and fixed an issue with user whitelist checks. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/existing_user_controller.cc
diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc
index 7300c312ad7adba72dd8c063911398f7cb4ac24c..5590ad009a41f88cd77380bef3e11c7f2ed184ab 100644
--- a/chrome/browser/chromeos/login/existing_user_controller.cc
+++ b/chrome/browser/chromeos/login/existing_user_controller.cc
@@ -104,14 +104,12 @@ void ExistingUserController::Init(const UserVector& users) {
&show_users_on_signin);
if (show_users_on_signin) {
bool allow_new_user = false;
- const base::ListValue *user_list;
cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
- cros_settings_->GetList(kAccountsPrefUsers, &user_list);
for (size_t i = 0; i < users.size(); ++i) {
- base::StringValue email(users[i].email());
// TODO(xiyuan): Clean user profile whose email is not in whitelist.
if (allow_new_user ||
- user_list->Find(email) != user_list->end()) {
+ cros_settings_->FindEmailInList(kAccountsPrefUsers,
+ users[i].email())) {
Mattias Nissler (ping if slow) 2011/10/28 14:44:07 This is actually changing semantics to also show u
pastarmovj 2011/11/18 13:18:42 Yes this is going to leave emails of people whitel
filtered_users.push_back(users[i]);
}
}

Powered by Google App Engine
This is Rietveld 408576698