PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/login/existing_user_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/existing_user_controller.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 86 matching lines @@
 void ExistingUserController::Init(const UserVector& users) {
   UserVector filtered_users;
   bool show_users_on_signin;
 
   // TODO(pastarmovj): Make this class an observer of the CrosSettings to be
   // able to update the UI whenever policy is loaded.
   cros_settings_->GetBoolean(kAccountsPrefShowUserNamesOnSignIn,
                              &show_users_on_signin);
   if (show_users_on_signin) {
     bool allow_new_user = false;
-    const base::ListValue *user_list;
     cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);
-    cros_settings_->GetList(kAccountsPrefUsers, &user_list);
     for (size_t i = 0; i < users.size(); ++i) {
-      base::StringValue email(users[i].email());
       // TODO(xiyuan): Clean user profile whose email is not in whitelist.
       if (allow_new_user ||
-          user_list->Find(email) != user_list->end()) {
+          cros_settings_->FindEmailInList(kAccountsPrefUsers,
+                                          users[i].email())) {

[Mattias Nissler (ping if slow), 2011/10/28 14:44:07]

This is actually changing semantics to also show user pods if you have
*@domain.com, correct? I'm fine with that, just checking.

[pastarmovj, 2011/11/18 13:18:42]

Yes this is going to leave emails of people whitelisted by wildcards which I
think is correct.

         filtered_users.push_back(users[i]);
       }
     }
   }
 
   // If no user pods are visible, fallback to single new user pod which will
   // have guest session link.
   bool show_guest;
   cros_settings_->GetBoolean(kAccountsPrefAllowGuest, &show_guest);
   show_guest &= !filtered_users.empty();
@@ skipping 488 matching lines @@
     std::string owner;
     cros_settings_->GetString(kDeviceOwner, &owner);
     cryptohomed->AsyncSetOwnerUser(owner, NULL);
     // Do not invoke AsyncDoAutomaticFreeDiskSpaceControl(NULL) here
     // so it does not delay the following mount. Cleanup will be
     // started in Cryptohomed by timer.
   }
 }
 
 }  // namespace chromeos