PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/login/login_performer.cc

Index: chrome/browser/chromeos/login/login_performer.cc
diff --git a/chrome/browser/chromeos/login/login_performer.cc b/chrome/browser/chromeos/login/login_performer.cc
index c6e857dd970a84ad17415414b7ce213ab258843f..7dbb91300d3176538c376b945fe3837c52955a43 100644
--- a/chrome/browser/chromeos/login/login_performer.cc
+++ b/chrome/browser/chromeos/login/login_performer.cc
@@ -281,10 +281,7 @@ void LoginPerformer::CompleteLogin(const std::string& username,
     StartLoginCompletion();
   } else {
     // Otherwise, do whitelist check first.
-    const base::ListValue *user_list;
-    base::StringValue username_value(username);
-    if (cros_settings->GetList(kAccountsPrefUsers, &user_list) &&
-        user_list->Find(username_value) != user_list->end()) {
+    if (cros_settings->FindEmailInList(kAccountsPrefUsers, username)) {

[Mattias Nissler (ping if slow), 2011/10/28 14:44:07]

why has this worked before if we didn't check *@domain.com?

[pastarmovj, 2011/11/18 13:18:42]

Because there is some code that whitelists existing users when the checkbox to
restrict users is clicked. However I haven't seen code that does this for cloud
policy so we might have had some issues there with that. Moreover this code will
not get run for new users logging for the first time so no issues there too.

       StartLoginCompletion();
     } else {
       if (delegate_)
@@ -326,10 +323,7 @@ void LoginPerformer::Login(const std::string& username,
     // Starts authentication if guest login is allowed or online auth pending.
     StartAuthentication();
   } else {
-    const base::ListValue *user_list;
-    base::StringValue username_value(username);
-    if (cros_settings->GetList(kAccountsPrefUsers, &user_list) &&
-        user_list->Find(username_value) != user_list->end()) {
+    if (cros_settings->FindEmailInList(kAccountsPrefUsers, username)) {
       StartAuthentication();
     } else {
       if (delegate_)