Disable the error reporting option for secured URL.

Disable the error reporting option for secured URL.

When there is a translate error, we should not let users report them because the report includes the sercured URL which would get compromised.

BUG=98441
TEST=Make sure the option is always disabled for secured (httpS) urls, and always enabled otherwise...

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103768

[MAD, 2011-09-30 18:05:49]

Sorry about that, needed to change the code because a Mac only test was failing
and I didn't notice (I thought it was just flakiness but I didn't look close
enough, it was a crash in the new code I wrote, BAD MAD... no cake!)...

So can you please take another look?

Now all try bots are green... :-)

Thanks!

[jochen (gone - plz use gerrit), 2011-09-30 18:22:17]

http://codereview.chromium.org/8086025/diff/3001/chrome/browser/translate/opt...
File chrome/browser/translate/options_menu_model.cc (right):

http://codereview.chromium.org/8086025/diff/3001/chrome/browser/translate/opt...
chrome/browser/translate/options_menu_model.cc:96: if (tab_contents) {
I think tab_contents can't be NULL. The constructor of TranslateInfobarDelegate
derefs tab_contents

http://codereview.chromium.org/8086025/diff/3001/chrome/browser/translate/opt...
chrome/browser/translate/options_menu_model.cc:98: if (entry)
shouldn't we rather return false if there's no entry? Also please add a comment
that entry might be NULL during tests

[MAD, 2011-09-30 19:20:20]

Good points... How about this?

Thanks!

BYE
MAD

[jochen (gone - plz use gerrit), 2011-09-30 19:25:44]

lgtm

[MAD, 2011-09-30 20:01:57]

On 2011/09/30 19:25:44, jochen wrote:
> lgtm

Thanks!

Now I need to merge and update the way I get to the tab_contents() of the
delegate, the carpet just got pulled off under my feet by another CL... :-(

[commit-bot: I haz the power, 2011-10-03 15:04:16]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/8086025/12001

[commit-bot: I haz the power, 2011-10-03 18:58:05]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/mad@chromium.org/8086025/14001

[commit-bot: I haz the power, 2011-10-03 20:15:22]

Change committed as 103768