Disable the error reporting option for secured URL.

chrome/browser/translate/options_menu_model.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/options_menu_model.h"
 
 #include "base/metrics/histogram.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 70 matching lines @@
 bool OptionsMenuModel::IsCommandIdEnabled(int command_id) const {
   switch (command_id) {
     case IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_LANG :
     case IDC_TRANSLATE_OPTIONS_NEVER_TRANSLATE_SITE :
       return !translate_infobar_delegate_->ShouldAlwaysTranslate();
 
     case IDC_TRANSLATE_OPTIONS_ALWAYS :
       return (!translate_infobar_delegate_->IsLanguageBlacklisted() &&
           !translate_infobar_delegate_->IsSiteBlacklisted());
 
+    case IDC_TRANSLATE_REPORT_BAD_LANGUAGE_DETECTION : {
+      // Until we have a secure URL for reporting language detection errors,
+      // we don't report errors that happened on secure URLs.
+      DCHECK(translate_infobar_delegate_ != NULL);
+      TabContents* tab_contents = translate_infobar_delegate_->tab_contents();
+      if (tab_contents) {

[jochen (gone - plz use gerrit), 2011/09/30 18:22:22]

I think tab_contents can't be NULL. The constructor of TranslateInfobarDelegate
derefs tab_contents

+        NavigationEntry* entry = tab_contents->controller().GetActiveEntry();
+        if (entry)

[jochen (gone - plz use gerrit), 2011/09/30 18:22:22]

shouldn't we rather return false if there's no entry? Also please add a comment
that entry might be NULL during tests

+          return !entry->url().SchemeIsSecure();
+      }
+    }
     default:
       break;
   }
   return true;
 }
 
 bool OptionsMenuModel::GetAcceleratorForCommandId(
     int command_id, ui::Accelerator* accelerator) {
   return false;
 }
@@ skipping 28 matching lines @@
             about_url, GURL(), NEW_FOREGROUND_TAB, PageTransition::LINK);
       }
       break;
     }
 
     default:
       NOTREACHED() << "Invalid command id from menu.";
       break;
   }
 }