Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: chrome/browser/translate/options_menu_model.cc

Issue 8086025: Disable the error reporting option for secured URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/options_menu_model.cc
===================================================================
--- chrome/browser/translate/options_menu_model.cc (revision 103693)
+++ chrome/browser/translate/options_menu_model.cc (working copy)
@@ -89,6 +89,18 @@
return (!translate_infobar_delegate_->IsLanguageBlacklisted() &&
!translate_infobar_delegate_->IsSiteBlacklisted());
+ case IDC_TRANSLATE_REPORT_BAD_LANGUAGE_DETECTION : {
+ // Until we have a secure URL for reporting language detection errors,
+ // we don't report errors that happened on secure URLs.
+ DCHECK(translate_infobar_delegate_ != NULL);
+ DCHECK(translate_infobar_delegate_->owner() != NULL);
+ DCHECK(translate_infobar_delegate_->owner()->tab_contents() != NULL);
+ NavigationEntry* entry = translate_infobar_delegate_->owner()->
+ tab_contents()->controller().GetActiveEntry();
+ // Delegate and tab contents should never be NULL, but active entry
+ // can be NULL when running tests. We want to return false if NULL.
+ return (entry != NULL) && !entry->url().SchemeIsSecure();
+ }
default:
break;
}
« no previous file with comments | « no previous file | chrome/browser/translate/translate_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698