Add interface to CancelableRequest that allows use of base::Callback<>.

Add interface to CancelableRequest that allows use of base::Callback<>.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103691

[awong, 2011-09-28 22:10:37]

Here's a proposed modification of the CancelableRequest API to work with
base::Callback<>.

Instead of:
   request->ForwardResult(FooRequest::TupleType(a, b))
you do
   request->ForwardResult(a, b)

This code does *not* compile yet. I need to fix
http://code.google.com/p/chromium/issues/detail?id=87287 for the syntax to fully
work out.

-Albert

[awong, 2011-10-01 01:11:57]

This is ready for review. 

Darin, Brett, if you two are too busy and there's another person who can do this
review, please feel free to forward.

[brettw, 2011-10-01 16:26:12]

LGTM

http://codereview.chromium.org/8068013/diff/8002/chrome/browser/icon_manager.h
File chrome/browser/icon_manager.h (right):

http://codereview.chromium.org/8068013/diff/8002/chrome/browser/icon_manager....
chrome/browser/icon_manager.h:74: typedef Callback2<Handle, gfx::Image*>::Type
OldIconRequestCallback;
It looks like you don't use this and you can just delete it.

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
File content/browser/cancelable_request.h (right):

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
content/browser/cancelable_request.h:583: void DoForward(const base::Closure&
forwarded_call, bool force_async) {
This should be non-inline (the whole point of the "base" class is to reduce
duplicated inline code).

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
content/browser/cancelable_request.h:620: void ExecuteCallback(const
base::Closure& forwarded_call) {
Ditto

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
content/browser/cancelable_request.h:743: // When suing this class, the provider
MUST call Init() (on the base class)
suing -> using

[awong, 2011-10-03 05:18:39]

Thanks Brett!

Fixed comments.  Will commit if it tries clean.

http://codereview.chromium.org/8068013/diff/8002/chrome/browser/icon_manager.h
File chrome/browser/icon_manager.h (right):

http://codereview.chromium.org/8068013/diff/8002/chrome/browser/icon_manager....
chrome/browser/icon_manager.h:74: typedef Callback2<Handle, gfx::Image*>::Type
OldIconRequestCallback;
On 2011/10/01 16:26:12, brettw wrote:
> It looks like you don't use this and you can just delete it.

Done.

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
File content/browser/cancelable_request.h (right):

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
content/browser/cancelable_request.h:583: void DoForward(const base::Closure&
forwarded_call, bool force_async) {
On 2011/10/01 16:26:12, brettw wrote:
> This should be non-inline (the whole point of the "base" class is to reduce
> duplicated inline code).

Done.

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
content/browser/cancelable_request.h:620: void ExecuteCallback(const
base::Closure& forwarded_call) {
On 2011/10/01 16:26:12, brettw wrote:
> Ditto

Done.

http://codereview.chromium.org/8068013/diff/8002/content/browser/cancelable_r...
content/browser/cancelable_request.h:743: // When suing this class, the provider
MUST call Init() (on the base class)
On 2011/10/01 16:26:12, brettw wrote:
> suing -> using

Done.

[commit-bot: I haz the power, 2011-10-03 06:43:07]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/ajwong@chromium.org/8068013/13001

[commit-bot: I haz the power, 2011-10-03 07:59:30]

Change committed as 103691