Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: chrome/browser/icon_manager.cc

Issue 8068013: Add interface to CancelableRequest that allows use of base::Callback<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address brett's comments. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/icon_manager.h ('k') | chrome/browser/ui/cocoa/download/download_item_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/icon_manager.cc
diff --git a/chrome/browser/icon_manager.cc b/chrome/browser/icon_manager.cc
index 22613dbea081afbdcb3db829975da6845a1aa699..e22ccefe34dd220a9f134706eefc43da864100c1 100644
--- a/chrome/browser/icon_manager.cc
+++ b/chrome/browser/icon_manager.cc
@@ -37,7 +37,7 @@ IconManager::Handle IconManager::LoadIcon(
const FilePath& file_name,
IconLoader::IconSize size,
CancelableRequestConsumerBase* consumer,
- IconRequestCallback* callback) {
+ const IconRequestCallback& callback) {
IconGroupID group = GetGroupIDFromFilepath(file_name);
IconRequest* request = new IconRequest(callback);
AddRequest(request, consumer);
@@ -83,8 +83,7 @@ bool IconManager::OnImageLoaded(IconLoader* source, gfx::Image* result) {
// Inform our client that the request has completed.
IconRequest* icon_request = client_request.request;
- icon_request->ForwardResult(IconRequest::TupleType(icon_request->handle(),
- result));
+ icon_request->ForwardResult(icon_request->handle(), result);
requests_.erase(rit);
return true; // Indicates we took ownership of result.
« no previous file with comments | « chrome/browser/icon_manager.h ('k') | chrome/browser/ui/cocoa/download/download_item_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698