chrome/browser/ui/cocoa/download/download_item_mac.mm - Issue 8068013: Add interface to CancelableRequest that allows use of base::Callback<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/download/download_item_mac.mm

Issue 8068013: Add interface to CancelableRequest that allows use of base::Callback<>. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address brett's comments. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/download/download_item_mac.mm

diff --git a/chrome/browser/ui/cocoa/download/download_item_mac.mm b/chrome/browser/ui/cocoa/download/download_item_mac.mm

index 6554be4ec414f759bd86b061d4aaa899aa520ba7..f1a4ad5367dd44b41e9fd05c8a26e257b1db5aee 100644

--- a/chrome/browser/ui/cocoa/download/download_item_mac.mm

+++ b/chrome/browser/ui/cocoa/download/download_item_mac.mm

@@ -87,8 +87,8 @@ void DownloadItemMac::LoadIcon() {

// The icon isn't cached, load it asynchronously.

icon_manager->LoadIcon(file, IconLoader::ALL, &icon_consumer_,

- NewCallback(this,

- &DownloadItemMac::OnExtractIconComplete));

+ base::Bind(&DownloadItemMac::OnExtractIconComplete,

+ base::Unretained(this)));

}

void DownloadItemMac::OnExtractIconComplete(IconManager::Handle handle,

« no previous file with comments | « chrome/browser/icon_manager.cc ('k') | chrome/browser/ui/gtk/download/download_item_gtk.cc » ('j') | no next file with comments »