Issue 8067: Make String Conversion Unittest x-platform + fix a small bug the tests expose...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8067: Make String Conversion Unittest x-platform + fix a small bug the tests expose... (Closed)

Created:
12 years, 2 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make String Conversion Unittest x-platform + fix a small bug the tests exposed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3760

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -73 lines)			Patch
M	base/base.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -0 lines	1 comment	Download
M	base/build/base_unittests.vcproj	View	1 chunk	+1 line, -1 line	1 comment	Download
M	base/sys_string_conversions_mac.mm	View	1 chunk	+2 lines, -1 line	1 comment	Download
A +	base/sys_string_conversions_unittest.cc	View	3 chunks	+12 lines, -8 lines	0 comments	Download
D	base/sys_string_conversions_win_unittest.cc	View	1 chunk	+0 lines, -63 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

12 years, 2 months ago (2008-10-22 20:02:31 UTC) #2

Nice work, LGTM

http://codereview.chromium.org/8067/diff/1/5
File base/base.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/8067/diff/1/5#newcode1487
Line 1487: B5D544AB0EAFB7E000272A1C /* sys_string_conversions_unittest.cc in
Sources */,
Sort :)

http://codereview.chromium.org/8067/diff/1/4
File base/build/base_unittests.vcproj (right):

http://codereview.chromium.org/8067/diff/1/4#newcode327
Line 327: RelativePath="..\sys_string_conversions_unittest.cc"
SConscript

http://codereview.chromium.org/8067/diff/1/6
File base/sys_string_conversions_mac.mm (right):

http://codereview.chromium.org/8067/diff/1/6#newcode64
Line 64: StringType ret(&out_buffer[0], elements - 1);
Good catch!

But can't we just do return StringType(&out_buffer[0], elements - 1) ?

Expand Messages | Collapse Messages