Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/sys_string_conversions_mac.mm

Issue 8067: Make String Conversion Unittest x-platform + fix a small bug the tests expose... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/build/base_unittests.vcproj ('K') | « base/build/base_unittests.vcproj ('k') | base/sys_string_conversions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_string_conversions_mac.mm
===================================================================
--- base/sys_string_conversions_mac.mm (revision 3750)
+++ base/sys_string_conversions_mac.mm (working copy)
@@ -61,7 +61,8 @@
return StringType();
out_buffer[elements - 1] = '\0';
- return StringType(&out_buffer[0]);
+ StringType ret(&out_buffer[0], elements - 1);
Mark Mentovai 2008/10/22 20:02:31 Good catch! But can't we just do return StringTyp
+ return ret;
}
// Given an STL string |in| with an encoding specified by |in_encoding|,
« base/build/base_unittests.vcproj ('K') | « base/build/base_unittests.vcproj ('k') | base/sys_string_conversions_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698