Make String Conversion Unittest x-platform + fix a small bug the tests expose...

base/sys_string_conversions_mac.mm

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sys_string_conversions.h"
 
 #import <Foundation/Foundation.h>
 
 #include <vector>
 
@@ skipping 43 matching lines @@
                                encoding,
                                0,      // lossByte
                                false,  // isExternalRepresentation
                                reinterpret_cast<UInt8*>(&out_buffer[0]),
                                out_size,
                                NULL);  // usedBufLen
   if (converted == 0)
     return StringType();
 
   out_buffer[elements - 1] = '\0';
-  return StringType(&out_buffer[0]);
+  StringType ret(&out_buffer[0], elements - 1);

[Mark Mentovai, 2008/10/22 20:02:31]

Good catch!

But can't we just do return StringType(&out_buffer[0], elements - 1) ?

+  return ret;
 }
 
 // Given an STL string |in| with an encoding specified by |in_encoding|,
 // convert it to |out_encoding| and return it as an STL string of the
 // |OutStringType| template type.  Returns an empty string on failure.
 //
 // Do not assert in this function since it is used by the asssertion code!
 template<typename InStringType, typename OutStringType>
 static OutStringType STLStringToSTLStringWithEncodingsT(
     const InStringType& in,
@@ skipping 103 matching lines @@
 
 std::string SysNSStringToUTF8(NSString* nsstring) {
   return SysCFStringRefToUTF8(reinterpret_cast<CFStringRef>(nsstring));
 }
 
 std::wstring SysNSStringToWide(NSString* nsstring) {
   return SysCFStringRefToWide(reinterpret_cast<CFStringRef>(nsstring));
 }
 
 }  // namespace base