Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: chrome/browser/chromeos/login/parallel_authenticator.cc

Issue 7982025: Made Authenticator::CompleteLogin, AuthenticateToLogin and AuthenticateToUnlock return void. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more obsolete comment fixed. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/parallel_authenticator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/parallel_authenticator.cc
diff --git a/chrome/browser/chromeos/login/parallel_authenticator.cc b/chrome/browser/chromeos/login/parallel_authenticator.cc
index 781f0901af078fb9ca0cd905973d8d36056233ef..cb130e39e826916fa7535669c154673873672496 100644
--- a/chrome/browser/chromeos/login/parallel_authenticator.cc
+++ b/chrome/browser/chromeos/login/parallel_authenticator.cc
@@ -105,7 +105,7 @@ ParallelAuthenticator::ParallelAuthenticator(LoginStatusConsumer* consumer)
ParallelAuthenticator::~ParallelAuthenticator() {}
-bool ParallelAuthenticator::AuthenticateToLogin(
+void ParallelAuthenticator::AuthenticateToLogin(
Profile* profile,
const std::string& username,
const std::string& password,
@@ -143,10 +143,9 @@ bool ParallelAuthenticator::AuthenticateToLogin(
NewRunnableMethod(this,
&ParallelAuthenticator::LoadLocalaccount,
std::string(kLocalaccountFile)));
- return true;
}
-bool ParallelAuthenticator::CompleteLogin(Profile* profile,
+void ParallelAuthenticator::CompleteLogin(Profile* profile,
const std::string& username,
const std::string& password) {
std::string canonicalized = Authenticator::Canonicalize(username);
@@ -188,10 +187,9 @@ bool ParallelAuthenticator::CompleteLogin(Profile* profile,
NewRunnableMethod(this,
&ParallelAuthenticator::LoadLocalaccount,
std::string(kLocalaccountFile)));
- return true;
}
-bool ParallelAuthenticator::AuthenticateToUnlock(const std::string& username,
+void ParallelAuthenticator::AuthenticateToUnlock(const std::string& username,
const std::string& password) {
current_state_.reset(
new AuthAttemptState(Authenticator::Canonicalize(username),
@@ -207,7 +205,6 @@ bool ParallelAuthenticator::AuthenticateToUnlock(const std::string& username,
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
NewRunnableMethod(key_checker_.get(), &CryptohomeOp::Initiate));
- return true;
}
void ParallelAuthenticator::LoginOffTheRecord() {
« no previous file with comments | « chrome/browser/chromeos/login/parallel_authenticator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698