Issue 7981001: Remove incorrect debug-code assertion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7981001: Remove incorrect debug-code assertion. (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove incorrect debug-code assertion. We should not use slot address to find out the page. This does not work for large pages. Also this assertion is not always true (violated during incremental marking). R=erik.corry@gmail.com TEST=mozilla/js1_5/extensions/regress-371636 Committed: http://code.google.com/p/v8/source/detail?r=9339

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	src/ia32/macro-assembler-ia32.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	src/x64/macro-assembler-x64.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages