Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 7981001: Remove incorrect debug-code assertion. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 j(cc, condition_met, condition_met_distance); 77 j(cc, condition_met, condition_met_distance);
78 } 78 }
79 79
80 80
81 void MacroAssembler::RememberedSetHelper( 81 void MacroAssembler::RememberedSetHelper(
82 Register addr, 82 Register addr,
83 Register scratch, 83 Register scratch,
84 SaveFPRegsMode save_fp, 84 SaveFPRegsMode save_fp,
85 MacroAssembler::RememberedSetFinalAction and_then) { 85 MacroAssembler::RememberedSetFinalAction and_then) {
86 Label done; 86 Label done;
87 if (FLAG_debug_code) {
88 Label ok;
89 JumpIfNotInNewSpace(addr, scratch, &ok, Label::kNear);
90 int3();
91 bind(&ok);
92 }
93 // Load store buffer top. 87 // Load store buffer top.
94 ExternalReference store_buffer = 88 ExternalReference store_buffer =
95 ExternalReference::store_buffer_top(isolate()); 89 ExternalReference::store_buffer_top(isolate());
96 mov(scratch, Operand::StaticVariable(store_buffer)); 90 mov(scratch, Operand::StaticVariable(store_buffer));
97 // Store pointer to buffer. 91 // Store pointer to buffer.
98 mov(Operand(scratch, 0), addr); 92 mov(Operand(scratch, 0), addr);
99 // Increment buffer top. 93 // Increment buffer top.
100 add(Operand(scratch), Immediate(kPointerSize)); 94 add(Operand(scratch), Immediate(kPointerSize));
101 // Write back new top of buffer. 95 // Write back new top of buffer.
102 mov(Operand::StaticVariable(store_buffer), scratch); 96 mov(Operand::StaticVariable(store_buffer), scratch);
(...skipping 2492 matching lines...) Expand 10 before | Expand all | Expand 10 after
2595 and_(bitmap_scratch, Immediate(~Page::kPageAlignmentMask)); 2589 and_(bitmap_scratch, Immediate(~Page::kPageAlignmentMask));
2596 add(Operand(bitmap_scratch, MemoryChunk::kLiveBytesOffset), 2590 add(Operand(bitmap_scratch, MemoryChunk::kLiveBytesOffset),
2597 length); 2591 length);
2598 2592
2599 bind(&done); 2593 bind(&done);
2600 } 2594 }
2601 2595
2602 } } // namespace v8::internal 2596 } } // namespace v8::internal
2603 2597
2604 #endif // V8_TARGET_ARCH_IA32 2598 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698