Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 7981001: Remove incorrect debug-code assertion. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 ASSERT(!with.AddressUsesRegister(kScratchRegister)); 194 ASSERT(!with.AddressUsesRegister(kScratchRegister));
195 LoadRoot(kScratchRegister, index); 195 LoadRoot(kScratchRegister, index);
196 cmpq(with, kScratchRegister); 196 cmpq(with, kScratchRegister);
197 } 197 }
198 198
199 199
200 void MacroAssembler::RememberedSetHelper(Register addr, 200 void MacroAssembler::RememberedSetHelper(Register addr,
201 Register scratch, 201 Register scratch,
202 SaveFPRegsMode save_fp, 202 SaveFPRegsMode save_fp,
203 RememberedSetFinalAction and_then) { 203 RememberedSetFinalAction and_then) {
204 if (FLAG_debug_code) {
205 Label ok;
206 JumpIfNotInNewSpace(addr, scratch, &ok, Label::kNear);
207 int3();
208 bind(&ok);
209 }
210 // Load store buffer top. 204 // Load store buffer top.
211 LoadRoot(scratch, Heap::kStoreBufferTopRootIndex); 205 LoadRoot(scratch, Heap::kStoreBufferTopRootIndex);
212 // Store pointer to buffer. 206 // Store pointer to buffer.
213 movq(Operand(scratch, 0), addr); 207 movq(Operand(scratch, 0), addr);
214 // Increment buffer top. 208 // Increment buffer top.
215 addq(scratch, Immediate(kPointerSize)); 209 addq(scratch, Immediate(kPointerSize));
216 // Write back new top of buffer. 210 // Write back new top of buffer.
217 StoreRoot(scratch, Heap::kStoreBufferTopRootIndex); 211 StoreRoot(scratch, Heap::kStoreBufferTopRootIndex);
218 // Call stub on end of buffer. 212 // Call stub on end of buffer.
219 Label done; 213 Label done;
(...skipping 3961 matching lines...) Expand 10 before | Expand all | Expand 10 after
4181 4175
4182 and_(bitmap_scratch, Immediate(~Page::kPageAlignmentMask)); 4176 and_(bitmap_scratch, Immediate(~Page::kPageAlignmentMask));
4183 addl(Operand(bitmap_scratch, MemoryChunk::kLiveBytesOffset), length); 4177 addl(Operand(bitmap_scratch, MemoryChunk::kLiveBytesOffset), length);
4184 4178
4185 bind(&done); 4179 bind(&done);
4186 } 4180 }
4187 4181
4188 } } // namespace v8::internal 4182 } } // namespace v8::internal
4189 4183
4190 #endif // V8_TARGET_ARCH_X64 4184 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698