Issue 7980063: Moved web_intent_service_data into webkit/glue

Issue 7980063: Moved web_intent_service_data into webkit/glue (Closed)

Created:
9 years, 3 months ago by groby-ooo-7-16

Modified:
9 years, 3 months ago

Reviewers:
tony, commit-bot: I haz the power, James Hawkins

CC:
chromium-reviews, dhollowa, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Moved web_intent_service_data into webkit/glue BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102273

Patch Set 2 : Fix review nit #

Total comments: 8

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -80 lines)			Patch
M	chrome/browser/intents/register_intent_handler_infobar_delegate.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/intents/register_intent_handler_infobar_delegate_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/intents/web_intent_service_data.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
D	chrome/browser/intents/web_intent_service_data.cc	View		1 chunk	+0 lines, -32 lines	0 comments	Download
M	chrome/browser/intents/web_intents_registry.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller_unittest.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/webdata/web_intents_table.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/webdata/web_intents_table_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
A +	webkit/glue/web_intent_service_data.h	View		0 chunks	+-1 lines, --1 lines	4 comments	Download
A +	webkit/glue/web_intent_service_data.cc	View	1	1 chunk	+3 lines, -2 lines	2 comments	Download
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

jhawkins: Please review tony: FYI, added two new files to webkit/glue

9 years, 3 months ago (2011-09-22 03:19:48 UTC) #1

James Hawkins

LGTM with nit. http://codereview.chromium.org/7980063/diff/1/webkit/glue/web_intent_service_data.cc File webkit/glue/web_intent_service_data.cc (right): http://codereview.chromium.org/7980063/diff/1/webkit/glue/web_intent_service_data.cc#newcode5 webkit/glue/web_intent_service_data.cc:5: #include <ostream> Blank line after this.

9 years, 3 months ago (2011-09-22 03:21:07 UTC) #2

groby-ooo-7-16

http://codereview.chromium.org/7980063/diff/1/webkit/glue/web_intent_service_data.cc File webkit/glue/web_intent_service_data.cc (right): http://codereview.chromium.org/7980063/diff/1/webkit/glue/web_intent_service_data.cc#newcode5 webkit/glue/web_intent_service_data.cc:5: #include <ostream> On 2011/09/22 03:21:07, James Hawkins wrote: > ...

9 years, 3 months ago (2011-09-22 03:34:05 UTC) #3

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/receiver/groby%40chromium.org/7980063/1014

9 years, 3 months ago (2011-09-22 14:28:37 UTC) #4

commit-bot: I haz the power

Can't apply patch for file webkit/glue/web_intent_service_data.cc. While running patch -p1 --forward --force; patching file webkit/glue/web_intent_service_data.cc ...

9 years, 3 months ago (2011-09-22 14:28:40 UTC) #5

tony

LGTM, but some style nits. http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_service_data.cc File webkit/glue/web_intent_service_data.cc (right): http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_service_data.cc#newcode17 webkit/glue/web_intent_service_data.cc:17: return (service_url == other.service_url ...

9 years, 3 months ago (2011-09-22 18:47:41 UTC) #6

groby-ooo-7-16

9 years, 3 months ago (2011-09-23 22:29:53 UTC) #7

Nits fixed in http://codereview.chromium.org/8028006

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_servi...
File webkit/glue/web_intent_service_data.cc (right):

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_servi...
webkit/glue/web_intent_service_data.cc:17: return (service_url ==
other.service_url &&
On 2011/09/22 18:47:42, tony wrote:
> Nit: Maybe drop the ()

Done.

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_servi...
File webkit/glue/web_intent_service_data.h (right):

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_servi...
webkit/glue/web_intent_service_data.h:5: #ifndef
CHROME_BROWSER_INTENTS_WEB_INTENT_SERVICE_DATA_H_
On 2011/09/22 18:47:42, tony wrote:
> Nit: Please update the include guard.

Done.

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/web_intent_servi...
webkit/glue/web_intent_service_data.h:15: // go in webkit/glue in
web_intent_data.
On 2011/09/22 18:47:42, tony wrote:
> Looks like we can remove this comment.

Done.

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/webkit_glue.gypi
File webkit/glue/webkit_glue.gypi (right):

http://codereview.chromium.org/7980063/diff/1014/webkit/glue/webkit_glue.gypi...
webkit/glue/webkit_glue.gypi:401: 'web_intent_service_data.h',
On 2011/09/22 18:47:42, tony wrote:
> Nit: ascii sort (web_io_operators.* is also in the wrong place-- that's not
your
> fault but may as well fix while you're here).

Done.

Expand Messages | Collapse Messages