webkit/glue/web_intent_service_data.cc - Issue 7980063: Moved web_intent_service_data into webkit/glue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: webkit/glue/web_intent_service_data.cc

Issue 7980063: Moved web_intent_service_data into webkit/glue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix review nit Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include <ostream>

	6

5 #include "base/utf_string_conversions.h"	7 #include "base/utf_string_conversions.h"

6 #include "chrome/browser/intents/web_intent_service_data.h"	8 #include "webkit/glue/web_intent_service_data.h"

7 #include <ostream>

8	9

9 WebIntentServiceData::WebIntentServiceData()	10 WebIntentServiceData::WebIntentServiceData()

10 : disposition(WebIntentServiceData::DISPOSITION_WINDOW) {	11 : disposition(WebIntentServiceData::DISPOSITION_WINDOW) {

11 }	12 }

12	13

13 WebIntentServiceData::~WebIntentServiceData() {}	14 WebIntentServiceData::~WebIntentServiceData() {}

14	15

15 bool WebIntentServiceData::operator==(const WebIntentServiceData& other) const {	16 bool WebIntentServiceData::operator==(const WebIntentServiceData& other) const {

16 return (service_url == other.service_url &&	17 return (service_url == other.service_url &&
	tony 2011/09/22 18:47:42 Nit: Maybe drop the () Nit: Maybe drop the () groby-ooo-7-16 2011/09/23 22:29:53 Done. Show quoted text On 2011/09/22 18:47:42, tony wrote: > Nit: Maybe drop the () Done.
17 action == other.action &&	18 action == other.action &&

18 type == other.type &&	19 type == other.type &&

19 title == other.title &&	20 title == other.title &&

20 disposition == other.disposition);	21 disposition == other.disposition);

21 }	22 }

22	23

23 std::ostream& operator<<(::std::ostream& os,	24 std::ostream& operator<<(::std::ostream& os,

24 const WebIntentServiceData& intent) {	25 const WebIntentServiceData& intent) {

25 return os <<	26 return os <<

26 "{" << intent.service_url <<	27 "{" << intent.service_url <<

27 ", " << UTF16ToUTF8(intent.action) <<	28 ", " << UTF16ToUTF8(intent.action) <<

28 ", " << UTF16ToUTF8(intent.type) <<	29 ", " << UTF16ToUTF8(intent.type) <<

29 ", " << UTF16ToUTF8(intent.title) <<	30 ", " << UTF16ToUTF8(intent.title) <<

30 ", " << intent.disposition <<	31 ", " << intent.disposition <<

31 "}";	32 "}";

32 }	33 }

OLD	NEW

« webkit/glue/web_intent_service_data.h ('K') | « webkit/glue/web_intent_service_data.h ('k') | webkit/glue/webkit_glue.gypi » ('j') | webkit/glue/webkit_glue.gypi » ('J')