Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 8028006: Fixed nits from move of web_intent_service_data.* to webkit/glue (Closed)

Created:
9 years, 3 months ago by groby-ooo-7-16
Modified:
9 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Fixed a few nits in web_intent_service_data.* and webkit_glue.gypi BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102789

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M webkit/glue/web_intent_service_data.h View 2 chunks +2 lines, -4 lines 0 comments Download
M webkit/glue/web_intent_service_data.cc View 1 chunk +5 lines, -5 lines 2 comments Download
M webkit/glue/webkit_glue.gypi View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
groby-ooo-7-16
9 years, 3 months ago (2011-09-23 22:30:17 UTC) #1
tony
Please use a more descriptive change description. E.g., specify what files you're cleaning up. LGTM ...
9 years, 3 months ago (2011-09-23 22:39:13 UTC) #2
groby-ooo-7-16
Header updated. http://codereview.chromium.org/8028006/diff/1/webkit/glue/web_intent_service_data.cc File webkit/glue/web_intent_service_data.cc (right): http://codereview.chromium.org/8028006/diff/1/webkit/glue/web_intent_service_data.cc#newcode18 webkit/glue/web_intent_service_data.cc:18: action == other.action && According to style ...
9 years, 3 months ago (2011-09-23 22:48:54 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/8028006/1
9 years, 2 months ago (2011-09-26 18:52:39 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-09-26 20:30:16 UTC) #5
Change committed as 102789

Powered by Google App Engine
This is Rietveld 408576698